Tekton Client plugin always runs on the Jenkins controller (Jenkins Agent Support)

[oleg-nenashev]

Tekton Client plugin steps is using the SimpleBuildStep API which requires provisioning of agent and workspace, Bit all steps actually run on the Jenkins server instance, Launcher remote calls are not invoked. It would be great to support actually running steps on agents

[oleg-nenashev]

If you do NOT want to support running on agents:

• Pending PR to support workspace-less SimpleBuildStep: [JENKINS-46175] SimpleBuildStep/SimpleBuildWrapper without workspace (alternative approach) jenkins#4829
• Alternative: https://www.jenkins.io/doc/developer/extensions/workflow-step-api/#step

[oleg-nenashev]

Example:

• perform() method invoke calls over remoting

  tekton-client-plugin/src/main/java/org/waveywaves/jenkins/plugins/tekton/client/build/create/CreateRaw.java

  Lines 192 to 210 in c081ba0

  	public void perform(@Nonnull Run<?, ?> run, @Nonnull FilePath workspace, @Nonnull Launcher launcher, @Nonnull TaskListener listener) throws InterruptedException, IOException {
  	consoleLogger = listener.getLogger();
  	// lets make sure the tekton client is not empty
  	if (tektonClient == null) {
  	setTektonClient(TektonUtils.getTektonClient());
  	if (tektonClient == null) {
  	throw new IOException("no tektonClient");
  	}
  	}
  	if (kubernetesClient == null) {
  	setKubernetesClient(TektonUtils.getKubernetesClient());
  	if (kubernetesClient == null) {
  	throw new IOException("no kubernetesClient");
  	}
  	}
  	EnvVars envVars = run.getEnvironment(listener);
  	runCreate(workspace, envVars);
  	}

• There is an API for that, e.g. invoking a call on the remote node: https://github.com/jenkinsci/custom-tools-plugin/blob/master/src/main/java/com/cloudbees/jenkins/plugins/customtools/CustomTool.java#L262-L295
• SimpleBuildStep#perform() API already provides the workspace variable which can be used for FilePath remote execution invocations

[jstrachan]

the plugin now works both in a controller and agent; we can maybe close this now?

[garethjevans]

@oleg-nenashev what I've noticed is that when I run this in a pipeline, it always requires an executor on the controller to start the PipelineRun, i'm guessing thats because we are using the perform method that takes in a FilePath workspace - I had to enable 2 executors on the controller on my test server to work around this (which is against recommendations)