Skip to content
This repository was archived by the owner on Apr 12, 2023. It is now read-only.

Clean-up code in dataplane.gobra #60

Open
LinoTelschow opened this issue Jan 27, 2022 · 0 comments
Open

Clean-up code in dataplane.gobra #60

LinoTelschow opened this issue Jan 27, 2022 · 0 comments

Comments

@LinoTelschow
Copy link
Collaborator

LinoTelschow commented Jan 27, 2022

As Is:

  • The old parser required adding some parentheses such that the file could be parsed.
    a map look-up needs the form (map)[key] instead of the regular notation map[key]
  • The original scion comments are annotated with a "(tlino) original SCION comment" suffix
  • To detailed comments like:
 // (tlino) use getters to simplify verification, need to use float64 cast since gobra
// (tlino) cannot cast a numeric argument to float64

To Be:

  • The extra parentheses are removed
  • remove these suffixes in the original SCION comments
  • simplify comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant