Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 supports #1

Open
peter279k opened this issue Jun 2, 2019 · 4 comments
Open

Python3 supports #1

peter279k opened this issue Jun 2, 2019 · 4 comments

Comments

@peter279k
Copy link

As title, I think it's time to let this elasticsearch-file-importer to support the Python 3.x version now.

@jadonn
Copy link
Owner

jadonn commented Oct 23, 2019

Hello @peter279k! I apologize for not responding to your issues sooner. I apparently did not know how to receive notifications about new issues. I admit I have not had a chance to really work with Python 3 yet, but I will look into it!

@peter279k
Copy link
Author

Hi @jadonn, I think this issue can be integrated with issue #2 I mention.

@jadonn
Copy link
Owner

jadonn commented Oct 23, 2019

I created a project in GitHub to try to organize issues for moving to Python 3. I am going to make a note that this issue should be for rewriting or making the code compatible with Python 3 if that is OK. So far I think one step is writing the tests as outlined in #2 and another step is updating the code. I will also add an issue for adding a requirements.txt. If there are other standard Python things that need to be added, I think those can have separate issues too.

@peter279k
Copy link
Author

Hi @jadonn. Thanks for your answer and quick reply!

I think it's fine to work on issue #2 firstly. And also integrate Travis CI build to run unit tests automatically.

I will take look at that issue and create related PR to resolve this issue :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants