Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security advice semver #590

Open
xuelink opened this issue Jan 27, 2024 · 7 comments · May be fixed by #629
Open

Security advice semver #590

xuelink opened this issue Jan 27, 2024 · 7 comments · May be fixed by #629

Comments

@xuelink
Copy link

xuelink commented Jan 27, 2024 •
edited
Loading 

$ npm audit

# npm audit report
semver  7.0.0 - 7.5.1
Severity: moderate
semver vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
fix available via `npm audit fix`
node_modules/simple-update-notifier/node_modules/semver
  simple-update-notifier  1.0.7 - 1.1.0
  Depends on vulnerable versions of semver
  node_modules/simple-update-notifier
    nodemon  2.0.19 - 2.0.22
    Depends on vulnerable versions of simple-update-notifier
    node_modules/@trapezedev/project/node_modules/nodemon

3 moderate severity vulnerabilities

$ npm ls simple-update-notifier
x@0.3.2 /Users/xl/Developer/x/x
└─┬ @capacitor/assets@3.0.4
  └─┬ @trapezedev/project@7.0.10
    └─┬ npm-watch@0.9.0
      └─┬ nodemon@2.0.22
        └── simple-update-notifier@1.1.0
@AntiGuideAkquinet
Copy link

This seems to be dependent on ionic-team/trapeze#200

@yndajas
Copy link

yndajas commented Jul 10, 2024

Could an additional override not be specified here to fix this?

@dtarnawsky dtarnawsky mentioned this issue Sep 25, 2024
Merged
@Yolgie
Copy link

Yolgie commented Nov 22, 2024

the dependency has been fixed upstream with trapeze 7.1.3 so we "just" need to update that here now :)

https://github.com/ionic-team/trapeze/releases/tag/7.1.3

@Yolgie Yolgie linked a pull request Nov 22, 2024 that will close this issue
Open
@Yolgie
Copy link

Yolgie commented Nov 22, 2024

had some minutes, created a pull request :)

@Yolgie
Copy link

Yolgie commented Jan 5, 2025

Unfortunately after nearly a year of this ticket being open and over a month and a half of a merge request that fixes this issue, nothing is happening :(

@wsamoht
Copy link

wsamoht commented Jan 6, 2025

For what it's worth, @trapezedev/project was fixed in 7.1.3 so doing a npm update will install that version and eliminate the security vulnerability being thrown with this package.

@AntiGuideAkquinet
Copy link

@markemer You seem to be the most recent contributor to this project. Could you maybe merge the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump trapeze to 7.1.3 (fixes #590) Yolgie/capacitor-assets
5 participants
@Yolgie @xuelink @wsamoht @yndajas @AntiGuideAkquinet