You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not everything will be possible without restartin cri-resource-manager (policy change) - but what ever we do early will improve usability and user expirience.
If we decide to depend on cri-resource-manager code - then we can just call nessesary "config validation" before it is passed down to shoot.
Then we can fail early - when reading extensions configmap.configs (based on ControllerDeployment.values0 , even before first shoot is created (with ControllerRegistration.policy=always) report that in ControllerInstallation object condidtion.
The configMap watcher maps that Shoot/Extensions (which may not exists) but can return error.
ppalucki
changed the title
Validate configruration before propagating to shoots using internal os CRI-RM
Validate configruration as early as possible - what ever is possible syntax/semantic - not everything is possible.
Oct 13, 2022
ppalucki
changed the title
Validate configruration as early as possible - what ever is possible syntax/semantic - not everything is possible.
Validate configruration as early as possible.
Oct 13, 2022
ppalucki
changed the title
Validate configruration as early as possible.
Validate configruration as early as possible - back propgate "rejected dynamic config" error
Oct 24, 2022
ppalucki
changed the title
Validate configruration as early as possible - back propgate "rejected dynamic config" error
Validate configruration as early as possible - backpropgate "rejected dynamic config" error
Oct 24, 2022
Not everything will be possible without restartin cri-resource-manager (policy change) - but what ever we do early will improve usability and user expirience.
If we decide to depend on cri-resource-manager code - then we can just call nessesary "config validation" before it is passed down to shoot.
Then we can fail early - when reading extensions configmap.configs (based on ControllerDeployment.values0 , even before first shoot is created (with ControllerRegistration.policy=always) report that in ControllerInstallation object condidtion.
The configMap watcher maps that Shoot/Extensions (which may not exists) but can return error.
cri-resmgr binaray can print whole dynamically created configuration ("-print-config") or even print helps ("config-help") as seen here: https://github.com/intel/cri-resource-manager/blob/master/cmd/cri-resmgr/main.go#L50 we should be able to call config.validate() if they make it public and other helper functions (SetConfig(programatically), SetConfigFromFile, Print)
depends on intel/cri-resource-manager#903
The text was updated successfully, but these errors were encountered: