Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate configruration as early as possible - backpropgate "rejected dynamic config" error #56

Open
ppalucki opened this issue Oct 7, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@ppalucki
Copy link
Contributor

ppalucki commented Oct 7, 2022

Not everything will be possible without restartin cri-resource-manager (policy change) - but what ever we do early will improve usability and user expirience.

If we decide to depend on cri-resource-manager code - then we can just call nessesary "config validation" before it is passed down to shoot.

Then we can fail early - when reading extensions configmap.configs (based on ControllerDeployment.values0 , even before first shoot is created (with ControllerRegistration.policy=always) report that in ControllerInstallation object condidtion.

The configMap watcher maps that Shoot/Extensions (which may not exists) but can return error.

cri-resmgr binaray can print whole dynamically created configuration ("-print-config") or even print helps ("config-help") as seen here: https://github.com/intel/cri-resource-manager/blob/master/cmd/cri-resmgr/main.go#L50 we should be able to call config.validate() if they make it public and other helper functions (SetConfig(programatically), SetConfigFromFile, Print)

depends on intel/cri-resource-manager#903

@ppalucki ppalucki added the enhancement New feature or request label Oct 7, 2022
@ppalucki ppalucki added this to the 1.1 milestone Oct 7, 2022
@ppalucki ppalucki self-assigned this Oct 7, 2022
@ppalucki ppalucki changed the title Validate configruration before propagating to shoots using internal os CRI-RM Validate configruration as early as possible - what ever is possible syntax/semantic - not everything is possible. Oct 13, 2022
@ppalucki ppalucki changed the title Validate configruration as early as possible - what ever is possible syntax/semantic - not everything is possible. Validate configruration as early as possible. Oct 13, 2022
@ppalucki ppalucki added the question Further information is requested label Oct 14, 2022
@ppalucki ppalucki changed the title Validate configruration as early as possible. Validate configruration as early as possible - back propgate "rejected dynamic config" error Oct 24, 2022
@ppalucki ppalucki changed the title Validate configruration as early as possible - back propgate "rejected dynamic config" error Validate configruration as early as possible - backpropgate "rejected dynamic config" error Oct 24, 2022
@ppalucki ppalucki modified the milestones: 1.1, 1.2, 1.3 Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants