Skip to content

Commit e3d8950

Browse files
author
Tyler Titsworth
authored
Add no-push parameter to build composite (#195)
* add no-push to builder arg * make repo and registry optional * fix shebang issue in idp shell * convert input to json for if * change eval criteria * switch to fromJSON
1 parent b847ad5 commit e3d8950

File tree

4 files changed

+13
-3
lines changed

4 files changed

+13
-3
lines changed

.github/action.yml

+10-2
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,19 @@ inputs:
1313
type: string
1414
registry:
1515
description: Container Registry URL
16-
required: true
16+
required: false
17+
default: 'intel'
1718
type: string
1819
repo:
1920
description: Container Project Repository
20-
required: true
21+
required: false
22+
default: 'ai-containers'
2123
type: string
24+
no-push:
25+
description: Do not push to Registry
26+
required: false
27+
default: false
28+
type: boolean
2229
runs:
2330
using: composite
2431
steps:
@@ -35,6 +42,7 @@ runs:
3542
working-directory: ${{ inputs.group_dir }}
3643
- name: Push Containers
3744
shell: bash
45+
if: ${{ !fromJson(inputs.no-push) }}
3846
run: |
3947
REGISTRY=${{ inputs.registry }} \
4048
REPO=${{ inputs.repo }} \

.github/linters/.hadolint.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,4 @@ ignored:
88
- DL4006
99
- SC1008
1010
- SC2140
11+
- SC2239

.github/workflows/container-pipeline-tester.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ jobs:
8787
env_overrides: ${{ inputs.env_overrides }}
8888
registry: ${{ vars.REGISTRY }}
8989
repo: ${{ vars.REPO }}
90+
no-push: false
9091
setup-test:
9192
needs: [ build-containers ]
9293
runs-on: [ k8-runners ]

python/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ ENV PATH /opt/conda/envs/idp/bin:/opt/conda/condabin:/opt/conda/bin/:${PATH}
6565
ENV LD_LIBRARY_PATH /lib64/:/usr/lib64/:/usr/local/lib64:/opt/conda/envs/idp/lib:${LD_LIBRARY_PATH}
6666

6767
RUN echo "conda activate idp" >> ~/.bashrc
68-
SHELL ["/opt/conda", "run", "-n", "idp", "/bin/bash", "-c"]
68+
SHELL ["conda", "run", "-n", "idp", "/bin/bash", "-c"]
6969

7070
RUN conda run -n idp python -m pip install --no-cache-dir numpy==1.22.4
7171

0 commit comments

Comments
 (0)