linting error fixed

Signed-off-by: sharvil10 <sharvil.shah@intel.com>

Author: sharvil10

enterprise/redhat/openshift-ai/gaudi/docker/builder/run

@@ -4,36 +4,36 @@ set -eo pipefail
 
 set -x
 
-APP_ROOT=${APP_ROOT:-/workspace}
+APP_ROOT=${APP_ROOT:-/opt/app-root}
 
 # Pre-clone repositories defined in JUPYTER_PRELOAD_REPOS
 if [ -n "${JUPYTER_PRELOAD_REPOS}" ]; then
-    for repo in `echo ${JUPYTER_PRELOAD_REPOS} | tr ',' ' '`; do
+    for repo in $(echo "${JUPYTER_PRELOAD_REPOS}" | tr ',' ' '); do
         # Check for the presence of "@branch" in the repo string
-        REPO_BRANCH=$(echo ${repo} | cut -s -d'@' -f2)
+        REPO_BRANCH=$(echo "${repo}" | cut -s -d'@' -f2)
         if [[ -n ${REPO_BRANCH} ]]; then
           # Remove the branch from the repo string and convert REPO_BRANCH to git clone arg
-          repo=$(echo ${repo} | cut -d'@' -f1)
+          repo=$(echo "${repo}" | cut -d'@' -f1)
           REPO_BRANCH="-b ${REPO_BRANCH}"
         fi
         echo "Checking if repository $repo exists locally"
-        REPO_DIR=$(basename ${repo})
+        REPO_DIR=$(basename "${repo}")
         if [ -d "${REPO_DIR}" ]; then
-            pushd ${REPO_DIR}
+            pushd "${REPO_DIR}"
             # Do nothing if the repo already exists
             echo "The ${repo} has already been cloned"
             :
             popd
         else
-            GIT_SSL_NO_VERIFY=true git clone ${repo} ${REPO_DIR} ${REPO_BRANCH}
+            GIT_SSL_NO_VERIFY=true git clone "${repo}" "${REPO_DIR}" "${REPO_BRANCH}"
         fi
     done
 fi
 
 if [ -n "${NOTEBOOK_SAMPLES_LINK}" ]; then
-    for link in `echo ${NOTEBOOK_SAMPLES_LINK} | tr ',' ' '`; do
-        wget ${link}
+    for link in $(echo "${NOTEBOOK_SAMPLES_LINK}" | tr ',' ' '); do
+        wget "${link}"
     done
 fi
 
-${APP_ROOT}/bin/start-notebook.sh "$@"
+"${APP_ROOT}"/bin/start-notebook.sh "$@"

enterprise/redhat/openshift-ai/gaudi/docker/install_efa.sh

@@ -18,10 +18,11 @@ DEFAULT_EFA_INSTALLER_VER=1.29.0
 efa_installer_version=${1:-$DEFAULT_EFA_INSTALLER_VER}
 
 tmp_dir=$(mktemp -d)
-wget -nv https://efa-installer.amazonaws.com/aws-efa-installer-$efa_installer_version.tar.gz -P $tmp_dir
-tar -xf $tmp_dir/aws-efa-installer-$efa_installer_version.tar.gz -C $tmp_dir
-pushd $tmp_dir/aws-efa-installer
-case $(. /etc/os-release ; echo -n $ID) in
+wget -nv https://efa-installer.amazonaws.com/aws-efa-installer-"$efa_installer_version".tar.gz -P "$tmp_dir"
+tar -xf "$tmp_dir"/aws-efa-installer-"$efa_installer_version".tar.gz -C "$tmp_dir"
+pushd "$tmp_dir"/aws-efa-installer
+# shellcheck disable=SC1091
+case $(. /etc/os-release ; echo -n "$ID") in
     rhel)
         # we cannot install dkms packages on RHEL images due to OCP rules
         rm -f RPMS/RHEL8/x86_64/dkms*.rpm
@@ -33,4 +34,4 @@ case $(. /etc/os-release ; echo -n $ID) in
 esac
 ./efa_installer.sh -y --skip-kmod --skip-limit-conf --no-verify
 popd
-rm -rf $tmp_dir
+rm -rf "$tmp_dir"

enterprise/redhat/openshift-ai/gaudi/docker/install_packages.sh

@@ -40,7 +40,7 @@ tmp_path=$(mktemp --directory)
 wget --no-verbose "${pt_artifact_path}/${pt_package_name}"
 tar -xf "${pt_package_name}" -C "${tmp_path}"/.
 pushd "${tmp_path}"
-./install.sh $VERSION $REVISION
+./install.sh "$VERSION" "$REVISION"
 popd
 # cleanup
 rm -rf "${tmp_path}" "${pt_package_name}"

enterprise/redhat/openshift-ai/gaudi/docker/start-notebook.sh

@@ -16,10 +16,12 @@
 
 # Load bash libraries
 SCRIPT_DIR=${APP_ROOT}/bin
-source ${SCRIPT_DIR}/utils/process.sh
+# shellcheck disable=SC1091
+source "${SCRIPT_DIR}"/utils/process.sh
 
 if [ -f "${SCRIPT_DIR}/utils/setup-elyra.sh" ]; then
-  source ${SCRIPT_DIR}/utils/setup-elyra.sh
+# shellcheck disable=SC1091
+  source "${SCRIPT_DIR}"/utils/setup-elyra.sh
 fi
 
 # Initialize notebooks arguments variable
@@ -47,9 +49,10 @@ if [ -n "${NOTEBOOK_ARGS}" ]; then
     NOTEBOOK_PROGRAM_ARGS+=${NOTEBOOK_ARGS}
 fi
 
-echo ${NOTEBOOK_PROGRAM_ARGS}
+echo "${NOTEBOOK_PROGRAM_ARGS}"
 
 # Start the JupyterLab notebook
+# shellcheck disable=SC2086
 start_process jupyter lab ${NOTEBOOK_PROGRAM_ARGS} \
     --ServerApp.ip=0.0.0.0 \
     --ServerApp.allow_origin="*" \

enterprise/redhat/openshift-ai/gaudi/docker/utils/process.sh

@@ -18,6 +18,7 @@ function start_process() {
     trap stop_process TERM INT
 
     echo "Running command:"  "$@"
+    echo -e "$@"
     "$@" &
 
     PID=$!
@@ -29,5 +30,5 @@ function start_process() {
 }
 
 function stop_process() {
-    kill -TERM $PID
+    kill -TERM "$PID"
 }