[FIX]stock_picking_state: domain for state_detail_id in tree view

Author: mav-adhoc

stock_picking_state/__manifest__.py

@@ -19,7 +19,7 @@
 ##############################################################################
 {
     "name": "Stock Picking State",
-    "version": "18.0.1.0.0",
+    "version": "18.0.1.1.0",
     "category": "Warehouse Management",
     "sequence": 14,
     "summary": "",

stock_picking_state/models/stock_picking.py

@@ -3,6 +3,7 @@
 # directory
 ##############################################################################
 from odoo import api, fields, models
+from odoo.exceptions import ValidationError
 
 
 class StockPicking(models.Model):
@@ -24,3 +25,11 @@ def change_state(self):
             if rec.state_detail_id and rec.state_detail_id in state_detail:
                 continue
             rec.state_detail_id = state_detail and state_detail[0]
+
+    @api.constrains("state_detail_id")
+    def change_state_detail_id(self):
+        for rec in self:
+            if rec.picking_type_id.code != rec.state_detail_id.picking_type or rec.state != rec.state_detail_id.state:
+                raise ValidationError(
+                    f"You're selecting a state detail that doesn’t belong to this state: {rec.state} or picking type: {rec.picking_type_id.code}"
+                )

stock_picking_state/views/stock_picking_views.xml

@@ -6,7 +6,7 @@
         <field name="inherit_id" ref="stock.vpicktree"/>
         <field name="arch" type="xml">
             <field name="state" position="after">
-                <field name="state_detail_id"/>
+                <field name="state_detail_id" domain="[('state','=', state),'|',('picking_type','=', picking_type_code), ('picking_type','=', False)]"/>
             </field>
         </field>
     </record>