-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HUGE performance issue with large datasets #57
Comments
I'm managing a fork of this project and our version numbers are out of sync now. I don't have time to submit a proper PR right now. Here's a gist: https://gist.github.com/musicin3d/3e0d411bb90f4d7c576537f00057e039 |
Much better. Performance issues are reduced drastically. We have about 3000 items, took about 45 seconds to load. with this update it take 5 seconds. |
it's good but the problem it's a bit slow when trying to delete the entry |
参见:indrimuska/jquery-editable-select#57 Signed-off-by: XiaZhengXin <xzx@xiazhengxin.name>
During initialization, you're running the filter() function after adding each list item. That filter function runs through the entire list of previously loaded items.
This is a BIG no-no. With 1000+ items, firefox grinds to a halt. In scientific terms, this is a time complexity of O(n^2). In less scientific terms, it's a CPU bomb.
Another PR is coming.
The text was updated successfully, but these errors were encountered: