New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix locking_test.go Integration Test #536

Open

samuel27m opened this issue Jan 27, 2025 · 1 comment

Member

samuel27m commented Jan 27, 2025 •

edited

Loading

The locking integration test has been failing for a while, but somehow the pipelines weren't failing:

This test needs to be fixed.

It seems that the 4 Signals emitted at the start are being lost when the Workflow is being reset: https://github.com/indeedeng/iwf/actions/runs/12913194642/job/36013969433#step:4:4287
And under some circumstances the internal channel size is also not matching as expected: https://github.com/indeedeng/iwf/actions/runs/12913194673/job/36009847771#step:4:2649

samuel27m changed the title ~~Fix Locking Integration Test~~ Fix locking_test.go Integration Test

Member Author

samuel27m commented Jan 27, 2025

This issue only applies to Temporal tests of locking_test.go Integration Test. The Cadence tests are passing as expected.

samuel27m mentioned this issue

IWF-472: Fix all the panic and enable test coverage #535

Merged

5 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment