Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEFECT] Optimizer type not modified in MultiRun Step #366

Closed
10 tasks done
GabrielSoto-INL opened this issue Jun 7, 2024 · 1 comment · Fixed by #367
Closed
10 tasks done

[DEFECT] Optimizer type not modified in MultiRun Step #366

GabrielSoto-INL opened this issue Jun 7, 2024 · 1 comment · Fixed by #367
Assignees
Labels
defect Something isn't working priority-minor tasks or issues that are not time-sensitive or critical

Comments

@GabrielSoto-INL
Copy link
Collaborator

GabrielSoto-INL commented Jun 7, 2024


Defect Description

Describe the defect

What did you expect to see happen?

When selecting the Bayesian Optimizer setting for optimization in a HERON input script and subsequently running HERON on the input script, the resulting outer.xml still has an optimization step in the <MultiRun> node that denotes the "GradientDescent" strategy instead.

I expected to see the BayesianOptimizer type specified in the <MultiRun> node.

NOTE: the Bayesian Optimization strategy is still used correctly since it calls on cap_opt which is defined to be a BayesianOpt node.

Do you have a suggested fix for the development team?

This should be fixed in template_driver.py.

Describe how to Reproduce
Steps to reproduce the behavior:
1.
2.
3.
4.

Screenshots and Input Files
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

Platform (please complete the following information):

  • OS: [e.g. iOS]
  • Version: [e.g. 22]
  • Dependencies Installation: [CONDA or PIP]

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@GabrielSoto-INL GabrielSoto-INL added defect Something isn't working priority-minor tasks or issues that are not time-sensitive or critical labels Jun 7, 2024
@GabrielSoto-INL GabrielSoto-INL self-assigned this Jun 7, 2024
@PaulTalbot-INL PaulTalbot-INL linked a pull request Jun 7, 2024 that will close this issue
9 tasks
@PaulTalbot-INL
Copy link
Collaborator

No impact on users, so no notifications required. Approved to close via #367 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working priority-minor tasks or issues that are not time-sensitive or critical
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants