Skip to content

Commit ff8b003

Browse files
authored
Merge pull request #52 from icon-project/IS-765-release-icon-sdk-python-develop-version
IS-765: Release icon-sdk-python develop branch
2 parents 0248b86 + 5c84648 commit ff8b003

14 files changed

+126
-118
lines changed

iconsdk/builder/call_builder.py

+9-9
Original file line numberDiff line numberDiff line change
@@ -29,22 +29,22 @@ def __init__(self, from_: str, to: str, method: str, params: dict):
2929
self.__params = params
3030

3131
@property
32-
def from_(self):
32+
def from_(self) -> str:
3333
return self.__from
3434

3535
@property
36-
def to(self):
36+
def to(self) -> str:
3737
return self.__to
3838

3939
@property
40-
def method(self):
40+
def method(self) -> str:
4141
return self.__method
4242

4343
@property
44-
def params(self):
44+
def params(self) -> dict:
4545
return convert_params_value_to_hex_str(self.__params) if self.__params else None
4646

47-
def to_dict(self):
47+
def to_dict(self) -> dict:
4848
return {"from_": self.from_, "to": self.to, "method": self.method, "params": self.params}
4949

5050

@@ -60,19 +60,19 @@ def __init__(self, from_: str = None, to: str = None, method: str = None, params
6060
self._method = method
6161
self._params = params
6262

63-
def from_(self, from_):
63+
def from_(self, from_: str) -> 'CallBuilder':
6464
self._from_ = from_
6565
return self
6666

67-
def to(self, to):
67+
def to(self, to: str) -> 'CallBuilder':
6868
self._to = to
6969
return self
7070

71-
def method(self, method):
71+
def method(self, method: str) -> 'CallBuilder':
7272
self._method = method
7373
return self
7474

75-
def params(self, params):
75+
def params(self, params: dict) -> 'CallBuilder':
7676
self._params = params
7777
return self
7878

iconsdk/builder/transaction_builder.py

+42-42
Original file line numberDiff line numberDiff line change
@@ -32,39 +32,39 @@ def __init__(self, from_: str, to: str, value: int, step_limit: int, nid: int, n
3232
self.__timestamp = timestamp
3333

3434
@property
35-
def from_(self):
35+
def from_(self) -> str:
3636
return self.__from
3737

3838
@property
39-
def to(self):
39+
def to(self) -> str:
4040
return self.__to
4141

4242
@property
43-
def value(self):
43+
def value(self) -> int:
4444
return self.__value
4545

4646
@property
47-
def step_limit(self):
47+
def step_limit(self) -> int:
4848
return self.__step_limit
4949

5050
@step_limit.setter
51-
def step_limit(self, step_limit):
51+
def step_limit(self, step_limit: int):
5252
self.__step_limit = step_limit
5353

5454
@property
55-
def nid(self):
55+
def nid(self) -> int:
5656
return self.__nid
5757

5858
@property
59-
def nonce(self):
59+
def nonce(self) -> int:
6060
return self.__nonce
6161

6262
@property
63-
def version(self):
63+
def version(self) -> int:
6464
return self.__version
6565

6666
@property
67-
def timestamp(self):
67+
def timestamp(self) -> int:
6868
return self.__timestamp
6969

7070
@property
@@ -75,7 +75,7 @@ def data_type(self):
7575
def data(self):
7676
return None
7777

78-
def to_dict(self):
78+
def to_dict(self) -> dict:
7979
return {"from_": self.from_, "to": self.to, "value": self.value, "step_limit": self.step_limit, "nid": self.nid,
8080
"nonce": self.nonce, "version": self.version, "timestamp": self.timestamp}
8181

@@ -96,22 +96,22 @@ def __init__(self, from_: str, to: str, value: int, step_limit: int, nid: int, n
9696
self.__params = params
9797

9898
@property
99-
def content_type(self):
99+
def content_type(self) -> str:
100100
return self.__content_type
101101

102102
@property
103-
def content(self):
103+
def content(self) -> bytes:
104104
return self.__content
105105

106106
@property
107-
def data_type(self):
107+
def data_type(self) -> str:
108108
return "deploy"
109109

110110
@property
111-
def params(self):
111+
def params(self) -> dict:
112112
return self.__params
113113

114-
def to_dict(self):
114+
def to_dict(self) -> dict:
115115
transaction_as_dict = super().to_dict()
116116
transaction_as_dict.update({"content_type": self.content_type, "content": self.content,
117117
"data_type": self.data_type, "params": self.params})
@@ -128,18 +128,18 @@ def __init__(self, from_: str, to: str, value: int, step_limit: int, nid: int, n
128128
self.__params = params
129129

130130
@property
131-
def method(self):
131+
def method(self) -> str:
132132
return self.__method
133133

134134
@property
135-
def data_type(self):
135+
def data_type(self) -> str:
136136
return "call"
137137

138138
@property
139-
def params(self):
139+
def params(self) -> dict:
140140
return self.__params
141141

142-
def to_dict(self):
142+
def to_dict(self) -> dict:
143143
transaction_as_dict = super().to_dict()
144144
transaction_as_dict.update({"method": self.method, "data_type": self.data_type, "params": self.params})
145145
return transaction_as_dict
@@ -158,14 +158,14 @@ def __init__(self, from_: str, to: str, value: int, step_limit: int, nid: int, n
158158
raise DataTypeException("Message data should be hex string prefixed with '0x'.")
159159

160160
@property
161-
def data_type(self):
161+
def data_type(self) -> str:
162162
return "message"
163163

164164
@property
165-
def data(self):
165+
def data(self) -> str:
166166
return self.__data
167167

168-
def to_dict(self):
168+
def to_dict(self) -> dict:
169169
transaction_as_dict = super().to_dict()
170170
transaction_as_dict.update({"data_type": self.data_type, "data": self.data})
171171
return transaction_as_dict
@@ -181,18 +181,18 @@ def __init__(self, from_: str, to: str, value: int, step_limit: int, nid: int, n
181181
self.__id = id
182182

183183
@property
184-
def data_type(self):
184+
def data_type(self) -> str:
185185
return "deposit"
186186

187187
@property
188-
def action(self):
188+
def action(self) -> str:
189189
return self.__action
190190

191191
@property
192-
def id(self):
192+
def id(self) -> str:
193193
return self.__id
194194

195-
def to_dict(self):
195+
def to_dict(self) -> dict:
196196
transaction_as_dict = super().to_dict()
197197
transaction_as_dict.update({"data_type": self.data_type, "action": self.action, "id": self.id})
198198
return transaction_as_dict
@@ -212,35 +212,35 @@ def __init__(self, from_: str = None, to: str = None, value: int = None, step_li
212212
self._version = version
213213
self._timestamp = timestamp
214214

215-
def from_(self, from_):
215+
def from_(self, from_: str) -> 'TransactionBuilder':
216216
self._from_ = from_
217217
return self
218218

219-
def to(self, to):
219+
def to(self, to: str) -> 'TransactionBuilder':
220220
self._to = to
221221
return self
222222

223-
def value(self, value):
223+
def value(self, value: int) -> 'TransactionBuilder':
224224
self._value = value
225225
return self
226226

227-
def step_limit(self, step_limit):
227+
def step_limit(self, step_limit: int) -> 'TransactionBuilder':
228228
self._step_limit = step_limit
229229
return self
230230

231-
def nid(self, nid):
231+
def nid(self, nid: int) -> 'TransactionBuilder':
232232
self._nid = nid
233233
return self
234234

235-
def nonce(self, nonce):
235+
def nonce(self, nonce: int) -> 'TransactionBuilder':
236236
self._nonce = nonce
237237
return self
238238

239-
def version(self, version):
239+
def version(self, version: int) -> 'TransactionBuilder':
240240
self._version = version
241241
return self
242242

243-
def timestamp(self, timestamp):
243+
def timestamp(self, timestamp: int) -> 'TransactionBuilder':
244244
self._timestamp = timestamp
245245
return self
246246

@@ -280,15 +280,15 @@ def __init__(self, from_: str = None, to: str = None, value: int = None, step_li
280280
self._content = content
281281
self._params = params
282282

283-
def content_type(self, content_type):
283+
def content_type(self, content_type: str) -> 'DeployTransactionBuilder':
284284
self._content_type = content_type
285285
return self
286286

287-
def content(self, content):
287+
def content(self, content: bytes) -> 'DeployTransactionBuilder':
288288
self._content = content
289289
return self
290290

291-
def params(self, params):
291+
def params(self, params: dict) -> 'DeployTransactionBuilder':
292292
self._params = params
293293
return self
294294

@@ -321,11 +321,11 @@ def __init__(self, from_: str = None, to: str = None, value: int = None, step_li
321321
self._method = method
322322
self._params = params
323323

324-
def method(self, method):
324+
def method(self, method: str) -> 'CallTransactionBuilder':
325325
self._method = method
326326
return self
327327

328-
def params(self, params):
328+
def params(self, params: dict) -> 'CallTransactionBuilder':
329329
self._params = params
330330
return self
331331

@@ -355,7 +355,7 @@ def __init__(self, from_: str = None, to: str = None, value: int = None, step_li
355355
TransactionBuilder.__init__(self, from_, to, value, step_limit, nid, nonce, version, timestamp)
356356
self._data = data
357357

358-
def data(self, data):
358+
def data(self, data: str) -> 'MessageTransactionBuilder':
359359
self._data = data
360360
return self
361361

@@ -386,11 +386,11 @@ def __init__(self, from_: str = None, to: str = None, value: int = None, step_li
386386
self._action = action
387387
self._id = id
388388

389-
def action(self, action: str):
389+
def action(self, action: str) -> 'DepositTransactionBuilder':
390390
self._action = action
391391
return self
392392

393-
def id(self, id: str):
393+
def id(self, id: str) -> 'DepositTransactionBuilder':
394394
self._id = id
395395
return self
396396

iconsdk/converter.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
# See the License for the specific language governing permissions and
1414
# limitations under the License.
1515

16+
from typing import Optional
17+
1618
from iconsdk.utils.convert_type import convert_hex_str_to_int, convert_hex_str_to_bytes
1719
from iconsdk.utils.hexadecimal import add_0x_prefix, is_0x_prefixed
1820
from iconsdk.utils.type import is_integer
@@ -48,7 +50,7 @@ def convert_transaction(transaction: dict):
4850
transaction[int_field] = convert_hex_str_to_int(transaction[int_field])
4951

5052

51-
def convert_block(data: dict):
53+
def convert_block(data: dict) -> Optional[dict]:
5254
"""
5355
Convert block data into the right format.
5456
It supports data about a block made not only from JSON RPC V3 but also from V2.

0 commit comments

Comments
 (0)