Merge pull request from GHSA-pmf5-wx49-g3fg

* fix(bts): Add check for nativecoin in transfer method #56

* fix(bts): Add checks for fees during registration #57

* fix(bts): Add negative check in tokenFallback #58

* fix(bts): Add fees to feeBalance after refund #59

* fix(bts): Reentrancy in refund #60

* fix(bmc): Avoid use of loop for fee gathering calculation #68

* fix(bmc): Relayer bond should be greater than zero #69

* fix(bmc): Relayer properties changed before distributing rewards #70

* fix(bts): Revert when registering coin of different name for preregistered address #52

* fix(bts): Use TokenLimitResponse in handleChangeTokenLimit #73

* fix(bts): balanceOf optimization #74

* fix(bts): Add checks earlier in transferBatch #75

* fix(bts): Make non-external function private #76

* fix(bts): Do not set refundable amount to zero on reclaim #77

* fix(bmc): feeGatheringNext for feeGatheringTerm

* fix(bts):fix incorrect operator for feeNumerator

* fix(bts):fix incorrect operator for fixedFee

* fix(bts):fix solidity version

* Revert "fix(bts):fix solidity version"

This reverts commit ed45276411ec8ee86b95511198390acad51d833a.

* fix(bts):fix revert message

* fix(bts):fix `this.<>` on local calls

* fix(bts):update `links` from internal to private

* fix(bts):fix duplicate address check

* fix(bts): Set limit on batch transfers #88

* fix(bts): Add checks for null value #88

* fix(bts):set max transfer batch number to 15

* fix(bts):set max transfer batch number to 15

* fix(bts): implement variable for maxBatchSize

* fix(bts): use batchSize limit on `balanceOfBatch()`

* fix(bts): use batchSize limit on `balanceOfBatch()`

* fix(bts): Add check for array size for consistency with solidity #88

* chore: Remove duplicate lines

* fix(bmr): Only forward events to the intended destination

* feat(bts): Remove this.<> for local calls to minimize gas #84

* fix(bts):fix range same as JAVA version

* fix(bts):Update deployment migration scripts for BTS

* fix(bts):Split BTS contracts to solve contract size limit for BTS

* fix(bts):New BTS Contract for OwnerManagement, solves contract max size

* fix(bts):add SPDX License

* fix(bts): Update BTSCore equivalent to V3

* fix(bts): Add BatchLimit on BTSPeriphery and handle versions of BTSPeriphery contract

* fix(bmc): Handle versions of BMCManagement contract

* feat: Solidity Contract migration scripts

* feat: Scripts for solidity contract upgrades

* refactor: Use internal keyword for variable

* feat: Update script for bmc management

* fix: Update nid of arctic testnet

* fix: Check status on transactions

* feat: Add BTSOwnerManager address to addresses.json file

* fix: snow mainnet endpoint fix

* fix: typo, address -> addresses

* fix: Add meaningful messages

* config: Split files into mainnet and testnet

* feat: Separate config for testnet and mainnet

* fix: Update deploy commands in docs

* fix: Coinnames

* fix: Script upgrades

* docs: Update docs to deploy on mainnet

* fix: Path for migrations file

* chore: Add build folder within devnet/docker/icon-bsc/

* chore: Fix typo

Co-authored-by: sdpbhandari <bhandari.sudeep68@gmail.com>

Author: izyak

.gitignore

@@ -5,7 +5,7 @@ __pycache__
 **/.DS_Store
 **/*.iml
 build/
-buildarctic/
+devnet/docker/icon-bsc/build*/
 bin/
 **/*/node_modules/
 abigenBindings/

devnet/docker/icon-bsc/Makefile

@@ -10,11 +10,27 @@ runnodes:
 deploysclocalnet:
 	./build.sh deploysclocalnet
 
-deploysctestnet:
-	./build.sh deploysctestnet
+# Usage: make deploysc net=mainnet/testnet
+deploysc:
+	./build.sh deploysc ${net}
 
+# Usage: make deployscarctic net=mainnet/testnet
 deployscarctic:
-	./build.sh deployscarctic
+	./build.sh deployscarctic ${net}
+
+############## AUDIT FIXES ############## 
+
+# Usage: make auditfixbsc net=mainnet
+auditfixbsc:
+	./build.sh bscaudit ${net}
+
+auditfixarctic:
+	./build.sh arcticaudit ${net}
+
+auditfixicon:
+	./build.sh iconaudit ${net}
+
+#########################################
 
 runrelaysrc:
 	./build.sh runrelaysrc

devnet/docker/icon-bsc/README.md

@@ -99,7 +99,12 @@ Description to the Alternative Deployment Processes:
 
     make buildsc                    #Builds smart contracts
 
-    make deploysctestnet           #Deploy smart contracts on Testnet. Using scripts/config.sh
+    make deploysc net=testnet       #Deploy smart contracts on Testnet. Using scripts/config/*
+        
+        Optional:
+
+        make deploysc net=mainnet   #Deploy smart contracts on mainnet
+        
 
     make runrelaysrc                #Run relay from source
 
@@ -110,8 +115,7 @@ Description to the Alternative Deployment Processes:
             make buildrelayimg      #Build relay docker image 
 
             make runrelayimg        #Run relay docker container
- 
-        Optional:
+
 
             make cleanartifacts     #Clean artifacts generated by smart contract deployment
 
@@ -307,13 +311,15 @@ The following must be installed on your PC to run Section 1.2 and Section 2
 
 ------------------------------------------------------------------------------------------------
 ICON-SNOW Deployment
-1. If you are looking to run a fresh ICON-SNOW deployment. linkfromarg should not be supplied. End result will be ICON-SNOW pair connected to each other only.
-
+1. If you are looking to run a fresh ICON-SNOW deployment. linkfromarg should not be supplied. End result will be ICON-SNOW pair connected to each other only. net can be mainnet or testnet.
+    ```sh
     make buildsc buildsuffix=arctic
-    make deployscarctic
+    make deployscarctic net=testnet
+    ```
 
 2. If you are looking to merge SNOW deployment with existing deployment (e.g. ICON-BSC). The linkfrom arg will use an absolute path to reference needed values (e.g. contract addresses of existing icon-bsc deployment). End result will be linked smart contracts from ICON-BSC-SNOW; thus BSC<=>SNOW transfer will also be possible.
-
+    ```sh
     make buildsc buildsuffix=arctic
-    make deployscarctic linkfrom=<absolute_path_to_ixh_folder_of_icon_bsc_deployment>
+    make deployscarctic net=testnet linkfrom=<absolute_path_to_ixh_folder_of_icon_bsc_deployment>
+    ```