Skip to content

Commit b17ec15

Browse files
authored
Merge branch 'main' into ics-20-irc20-support
2 parents 662abf8 + 5bd6c10 commit b17ec15

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

.github/workflows/runner-start.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
repository: icon-project/ibc-relay
4141
- name: Start EC2 instance
4242
id: start
43-
uses: machulav/ec2-github-runner
43+
uses: machulav/ec2-github-runner@v2
4444
with:
4545
mode: start
4646
github-token: ${{ secrets.GH_RUNNER_PAT }}
@@ -49,4 +49,4 @@ jobs:
4949
subnet-id: subnet-f1fcd4df
5050
security-group-id: sg-03cb8034e27e1caeb
5151
pre-runner-script: |
52-
./build.sh ${{ inputs.relayer_version == '' && steps.relay.outputs.release || inputs.relayer_version }}
52+
./build.sh ${{ inputs.relayer_version == '' && steps.relay.outputs.release || inputs.relayer_version }}

docs/adr/ICON_IBC.md

+15-1
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,24 @@ func updateConnectionCommitment(connection):
3434
sendBTPMessage(join(clientKey, clientState));
3535
sendBTPMessage(join(consensusKey, latestConsensusState));
3636
sendBTPMessage(join(connectionKey, connection))
37-
}
37+
3838
```
3939

4040
During connection establishment all self client validation is skipped, and will have to be done manually when opening a new channel.
41+
### Manual connection verification
42+
(These steps can be omitted if the connection was established by a relay that you trust)
43+
To verify that a counterparty has stored the correct clientState or consensus state, find the latest BTP block that should be on the client and compare that to what is on the light client.
44+
Easiest way is to manually verify it on the counterparty client by fetching the client or consensus state directly from the client. But can also be proved through verifyMembership on the lightClient on ICON.
45+
46+
A btp block can be fetched [Block](https://github.com/icon-project/goloop/blob/master/doc/btp2_extension.md) GET request.
47+
Which can then be compared with the states in the light client:
48+
```
49+
GetConsensusState { client_id: String, height: u64 },
50+
#[returns(Vec<u8>)]
51+
GetLatestConsensusState { client_id: String },
52+
#[returns(Vec<u8>)]
53+
GetClientState { client_id: String },
54+
```
4155

4256
## ICS-04
4357
For BTP blocks and the ICON lightclient we have two restrictions:

0 commit comments

Comments
 (0)