Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Proxy Matcher util #3850

Open
seanmonstar opened this issue Mar 3, 2025 · 3 comments
Open

Create Proxy Matcher util #3850

seanmonstar opened this issue Mar 3, 2025 · 3 comments
Labels
A-client Area: client. C-feature Category: feature. This is adding a new feature. K-hyper-util Crate: hyper-util

Comments

@seanmonstar
Copy link
Member

Create a type in hyper_util::client::proxy that can be configured with proxy matching rules. It should be easy to also construct one based of environment variables, or system proxies.

Note, this isn't a proxy Service. Just a type that when we ask "does this URL need a proxy", it can answer with the proxy's URL, type, auth, etc.

For prior art, there's a similar type used internally in reqwest.

@seanmonstar seanmonstar added A-client Area: client. C-feature Category: feature. This is adding a new feature. K-hyper-util Crate: hyper-util labels Mar 3, 2025
@andrzejSulkowski
Copy link

I'd like to try this one. I might need some guidance though as this is my first PR on this repo. If you agree please assign it to me

@seanmonstar
Copy link
Member Author

That's great! For what it's worth, I partially started porting over the type from reqwest, but got then paused while I planned out the larger project. I've submitted a draft PR with what I had so far: hyperium/hyper-util#171

@andrzejSulkowski
Copy link

Can I push on your draft PR or should I branch out and create a new PR for you to review @seanmonstar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-client Area: client. C-feature Category: feature. This is adding a new feature. K-hyper-util Crate: hyper-util
Projects
None yet
Development

No branches or pull requests

2 participants