Skip to content

Commit 4a9cdc2

Browse files
committed
test: update client_http2_upgrade test
1 parent 6a90194 commit 4a9cdc2

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

tests/legacy_client.rs

+5-6
Original file line numberDiff line numberDiff line change
@@ -807,7 +807,7 @@ fn client_upgrade() {
807807
assert_eq!(vec, b"bar=foo");
808808
}
809809

810-
#[cfg(not(miri))]
810+
// #[cfg(not(miri))]
811811
#[test]
812812
fn client_http2_upgrade() {
813813
use http::{Method, Response, Version};
@@ -835,7 +835,7 @@ fn client_http2_upgrade() {
835835
let _ = builder
836836
.serve_connection_with_upgrades(
837837
stream,
838-
service_fn(|mut req| async move {
838+
service_fn(|req| async move {
839839
assert_eq!(req.headers().get("host"), None);
840840
assert_eq!(req.version(), Version::HTTP_2);
841841
assert_eq!(
@@ -847,9 +847,8 @@ fn client_http2_upgrade() {
847847
Some(&hyper::ext::Protocol::from_static("websocket"))
848848
);
849849

850-
let on_upgrade = req.extensions_mut().remove::<hyper::upgrade::OnUpgrade>();
850+
let on_upgrade = hyper::upgrade::on(req);
851851
tokio::spawn(async move {
852-
let on_upgrade = on_upgrade.unwrap();
853852
let upgraded = on_upgrade.await.unwrap();
854853
let mut io = TokioIo::new(upgraded);
855854

@@ -869,16 +868,16 @@ fn client_http2_upgrade() {
869868
let req = Request::builder()
870869
.method(Method::CONNECT)
871870
.uri(&*format!("http://{}/up", addr))
872-
.version(Version::HTTP_2)
873871
.header(http::header::SEC_WEBSOCKET_VERSION, "13")
872+
.version(Version::HTTP_2)
874873
.extension(hyper::ext::Protocol::from_static("websocket"))
875874
.body(Empty::<Bytes>::new())
876875
.unwrap();
877876

878877
let res = client.request(req);
879878
let res = rt.block_on(res).unwrap();
880879

881-
assert_eq!(res.status(), 200);
880+
assert_eq!(res.status(), http::StatusCode::OK);
882881
assert_eq!(res.version(), Version::HTTP_2);
883882

884883
let upgraded = rt.block_on(hyper::upgrade::on(res)).expect("on_upgrade");

0 commit comments

Comments
 (0)