removing external calls to libraries #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -289,17 +289,6 @@ | |||
| en alguno de los POIs que aparecen en el mapa luego de | |||
| seleccionar algunos de la lista.</p> | |||
|
|
|||
| <p>También puedes crear tu propia consulta utilizando | |||
There was a problem hiding this comment.
¿Esta sección la quitaste por algo en particular o se te olvidó volver a agregarla en otra parte?
|
¿Probaste los cambios que hiciste localmente en tu pc? ¿Te funcionó? Si no, ¿qué problemas tuviste? Es muy importante que antes de hacer un PR puedas probar los cambios en tu equipo así no enviás algo que no funciona. Por ejemplo, yo apliqué los 2 PR que enviaste y veo que Firefox me da algunos errores:
Para abrir esa ventana con información de depuración, utilicé ¿Podrías resolver eso y volver a enviar el PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
editing the index to make the libraries be local. based in: https://github.com/51114u9/osm-pois/blob/master/web/index.html