Add $ to the end of filename regex patterns (#931)

And add an unrelated test for a model with modeling files in a subfolder and configuration files in the root. This passes on main, but failed on 1.19.0

Author: tomaarsen

optimum/intel/openvino/modeling_base.py

@@ -439,7 +439,7 @@ def from_pretrained(
 
             ov_files = _find_files_matching_pattern(
                 model_dir,
-                pattern=r"(.*)?openvino(.*)?\_model.xml",
+                pattern=r"(.*)?openvino(.*)?\_model.xml$",
                 subfolder=subfolder,
                 use_auth_token=token,
                 revision=revision,

optimum/intel/openvino/modeling_open_clip.py

@@ -152,7 +152,7 @@ def from_pretrained(
 
             ov_files = _find_files_matching_pattern(
                 model_dir,
-                pattern=r"(.*)?openvino(.*)?\_model\_(.*)?.xml",
+                pattern=r"(.*)?openvino(.*)?\_model\_(.*)?.xml$",
                 subfolder=subfolder,
                 use_auth_token=token,
                 revision=revision,

tests/openvino/test_modeling.py

@@ -339,7 +339,7 @@ def test_infer_export_when_loading(self):
 
     def test_find_files_matching_pattern(self):
         model_id = "echarlaix/tiny-random-PhiForCausalLM"
-        pattern = r"(.*)?openvino(.*)?\_model.xml"
+        pattern = r"(.*)?openvino(.*)?\_model.xml$"
         # hub model
         for revision in ("main", "ov", "itrex"):
             ov_files = _find_files_matching_pattern(
@@ -360,7 +360,7 @@ def test_find_files_matching_pattern(self):
 
     @parameterized.expand(("stable-diffusion", "stable-diffusion-openvino"))
     def test_find_files_matching_pattern_sd(self, model_arch):
-        pattern = r"(.*)?openvino(.*)?\_model.xml"
+        pattern = r"(.*)?openvino(.*)?\_model.xml$"
         model_id = MODEL_NAMES[model_arch]
         # hub model
         ov_files = _find_files_matching_pattern(model_id, pattern=pattern)
@@ -374,6 +374,23 @@ def test_find_files_matching_pattern_sd(self, model_arch):
             ov_files = _find_files_matching_pattern(local_dir, pattern=pattern)
             self.assertTrue(len(ov_files) > 0 if "openvino" in model_id else len(ov_files) == 0)
 
+    @parameterized.expand(("", "openvino"))
+    def test_find_files_matching_pattern_with_config_in_root(self, subfolder):
+        # Notably, the model has a config.json file in the root directory and not in the subfolder
+        model_id = "sentence-transformers-testing/stsb-bert-tiny-openvino"
+        pattern = r"(.*)?openvino(.*)?\_model.xml$"
+        # hub model
+        ov_files = _find_files_matching_pattern(model_id, pattern=pattern, subfolder=subfolder)
+        self.assertTrue(len(ov_files) == 1 if subfolder == "openvino" else len(ov_files) == 0)
+
+        # local model
+        api = HfApi()
+        with tempfile.TemporaryDirectory() as tmpdirname:
+            local_dir = Path(tmpdirname) / "model"
+            api.snapshot_download(repo_id=model_id, local_dir=local_dir)
+            ov_files = _find_files_matching_pattern(local_dir, pattern=pattern, subfolder=subfolder)
+            self.assertTrue(len(ov_files) == 1 if subfolder == "openvino" else len(ov_files) == 0)
+
 
 class PipelineTest(unittest.TestCase):
     def test_load_model_from_hub(self):