Skip to content

Commit 6cc2de5

Browse files
authored
Apply suggestions from code review
1 parent 1699f32 commit 6cc2de5

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

optimum/exporters/openvino/__main__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ def maybe_convert_tokenizers(library_name: str, output: Path, model=None, prepro
541541
try:
542542
export_tokenizer(tokenizer, output, task=task, additional_chat_templates=additional_chat_templates)
543543
except Exception as exception:
544-
logger.warn(
544+
logger.warning(
545545
"Could not load tokenizer using specified model ID or path. OpenVINO tokenizer/detokenizer "
546546
f"models won't be generated. Exception: {exception}"
547547
)

optimum/intel/openvino/modeling_seq2seq.py

-9
Original file line numberDiff line numberDiff line change
@@ -572,15 +572,6 @@ def __init__(self, model: openvino.runtime.Model, parent_model: OVModelForSeq2Se
572572
self.key_value_input_names = [key for key in self.input_names if "key_values" in key]
573573
self.output_names = {key.get_any_name(): idx for idx, key in enumerate(self.model.outputs)}
574574
self.output_dtypes = {key.get_any_name(): key.get_element_type().get_type_name() for key in self.model.outputs}
575-
if self.key_value_input_names:
576-
self.key_value_output_names = []
577-
for i in range(6):
578-
self.key_value_output_names.extend([f"present.{i}.decoder.key", f"present.{i}.decoder.value"])
579-
else:
580-
self.key_value_output_names = []
581-
for i in range(6):
582-
self.key_value_output_names.extend([f"present.{i}.decoder.key", f"present.{i}.decoder.value", f"present.{i}.encoder.key", f"present.{i}.encoder.value"])
583-
584575
self.key_value_output_names = [key for key in self.output_names if "key_values" in key or "present" in key]
585576
self.stateful = model_has_state(self.model)
586577
is_legacy = any("past_key_values" in key.get_any_name() for key in self.model.outputs)

0 commit comments

Comments
 (0)