Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: monorepo maintenance #990

Open
4 of 13 tasks
BarryThePenguin opened this issue Mar 1, 2025 · 9 comments
Open
4 of 13 tasks

Meta: monorepo maintenance #990

BarryThePenguin opened this issue Mar 1, 2025 · 9 comments

Comments

@BarryThePenguin
Copy link
Contributor

BarryThePenguin commented Mar 1, 2025

Hi 👋🏻 would the Hono devs be interested in reviewing contributions to the configuration and maintenance of the monorepo? Some ideas I have include..

I'm happy to volunteer, I'll aim to keep changes small and focused. I'm just gauging the interest of others to review the changes, and if these kinds of changes would be useful for the project 👀

@yusukebe
Copy link
Member

yusukebe commented Mar 2, 2025

Hi @BarryThePenguin !

I am super interested in your proposal! The maintainability will be greatly improved.

All 5 thins you picked up are good to do. Regarding monorepo, we were discussing moving package manager to Bun and using Bun's workspace. #628

It may be good to start with migration using Bun.

cc: @gunta @nakasyou

@nakasyou
Copy link
Contributor

nakasyou commented Mar 2, 2025

That's a good idea! However to use Bun, we need to match all packages with the latest Hono.

@yusukebe
Copy link
Member

yusukebe commented Mar 2, 2025

However to use Bun, we need to match all packages with the latest Hono.

This will be a pain point. Ideally, all packages should pass the test using the latest version of Hono, but I think that's difficult.

It might be better to continue using yarn. We could use pnpm, but since we don't use it in any of the other projects in honojs, I think it's fine to use yarn.

@BarryThePenguin
Copy link
Contributor Author

Ok, I think sticking with yarn for the short term would work best. With a longer term goal of adopting bun, once some of the more pressing maintenance issue have been resolved.

However to use Bun, we need to match all packages with the latest Hono.

I'll keep this in mind 👍🏻

@yusukebe
Copy link
Member

yusukebe commented Mar 2, 2025

@BarryThePenguin Thanks! Can you proceed with it?

@BarryThePenguin
Copy link
Contributor Author

Sure thing 👍🏻 I'll start with #994, then I'll look at what is involved in enabling vitest.workspace.

Please feel free to add/remove/rearrange items in the list above and I can work through them as I have time

@yusukebe
Copy link
Member

yusukebe commented Mar 2, 2025

@BarryThePenguin Thaaaanks!

@MathurAditya724
Copy link
Contributor

Hey, @BarryThePenguin, I was thinking of working on the ESLint part of the repo. If no one else is working on it, I can start creating a PR for it.

@BarryThePenguin
Copy link
Contributor Author

Hi @MathurAditya724, sounds good! 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants