-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(30463): Fix bugs in the OpenAPI specs of the data combining feature #822
refactor(30463): Fix bugs in the OpenAPI specs of the data combining feature #822
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one wording change for id vs name.
Incorrect specifications of the routes; need fix |
d2213aa
to
59fffb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have two open api specs, this one and the 2025.4-SNAPSHOT one, we must decide on which one to use
…lter) and update the DataCombining schema
8ae06ca
to
a224a48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about XML naming conventions.
See https://hivemq.kanbanize.com/ctrl_board/57/cards/30463/details/
Implementing the frontend part of the
data combining
has highlighted a few mis-specifications of the API that need correction. Most are cosmetic changes (reorganised the structure of schemas to facilitate the visualisation of the editor), but a few are breaking changes:schema
property is added to thedestination
ofDataCombining
DataIdentifier
schema is being created to provide a "namespaced" reference to bothtags
and `topic filtersGET /api/v1/management/topic-filters/{filter}
GET /api/v1/management/topic-filters/{filter}/schema
Out-of-scope
items: {}
in schemas). They will be dealt with in another ticket