test: fix invalid field being passed on (#981)

The first step in this test case sets the `datacenter`, but all follow
up steps copy the `location` argument.

Author: apricote

internal/server/resource_test.go

@@ -13,6 +13,7 @@ import (
 	"github.com/stretchr/testify/assert"
 
 	"github.com/hetznercloud/hcloud-go/hcloud"
+
 	"github.com/hetznercloud/terraform-provider-hcloud/internal/firewall"
 	"github.com/hetznercloud/terraform-provider-hcloud/internal/image"
 	"github.com/hetznercloud/terraform-provider-hcloud/internal/network"
@@ -566,12 +567,12 @@ func TestServerResource_PrimaryIPNetworkTests(t *testing.T) {
 	sResWithNetAndPublicNet.SetRName(sResWithNetAndPublicNet.Name)
 
 	sResWithoutPublicNet := &server.RData{
-		Name:         sResWithNetAndPublicNet.Name,
-		Type:         sResWithNetAndPublicNet.Type,
-		LocationName: sResWithNetAndPublicNet.LocationName,
-		Image:        sResWithNetAndPublicNet.Image,
-		SSHKeys:      sResWithNetAndPublicNet.SSHKeys,
-		Networks:     sResWithNetAndPublicNet.Networks,
+		Name:       sResWithNetAndPublicNet.Name,
+		Type:       sResWithNetAndPublicNet.Type,
+		Datacenter: sResWithNetAndPublicNet.Datacenter,
+		Image:      sResWithNetAndPublicNet.Image,
+		SSHKeys:    sResWithNetAndPublicNet.SSHKeys,
+		Networks:   sResWithNetAndPublicNet.Networks,
 		PublicNet: map[string]interface{}{
 			"ipv4_enabled": false,
 			"ipv6_enabled": false,
@@ -581,12 +582,12 @@ func TestServerResource_PrimaryIPNetworkTests(t *testing.T) {
 	sResWithoutPublicNet.SetRName(sResWithoutPublicNet.Name)
 
 	sResWithPrimaryIP := &server.RData{
-		Name:         sResWithoutPublicNet.Name,
-		Type:         sResWithoutPublicNet.Type,
-		LocationName: sResWithoutPublicNet.LocationName,
-		Image:        sResWithoutPublicNet.Image,
-		SSHKeys:      sResWithoutPublicNet.SSHKeys,
-		Networks:     sResWithoutPublicNet.Networks,
+		Name:       sResWithoutPublicNet.Name,
+		Type:       sResWithoutPublicNet.Type,
+		Datacenter: sResWithoutPublicNet.Datacenter,
+		Image:      sResWithoutPublicNet.Image,
+		SSHKeys:    sResWithoutPublicNet.SSHKeys,
+		Networks:   sResWithoutPublicNet.Networks,
 		PublicNet: map[string]interface{}{
 			"ipv4_enabled": true,
 			"ipv4":         primaryIPv4Res.TFID() + ".id",
@@ -598,12 +599,12 @@ func TestServerResource_PrimaryIPNetworkTests(t *testing.T) {
 	sResWithPrimaryIP.SetRName(sResWithPrimaryIP.Name)
 
 	sResWithTwoPrimaryIPs := &server.RData{
-		Name:         sResWithPrimaryIP.Name,
-		Type:         sResWithPrimaryIP.Type,
-		LocationName: sResWithPrimaryIP.LocationName,
-		Image:        sResWithPrimaryIP.Image,
-		SSHKeys:      sResWithPrimaryIP.SSHKeys,
-		Networks:     sResWithPrimaryIP.Networks,
+		Name:       sResWithPrimaryIP.Name,
+		Type:       sResWithPrimaryIP.Type,
+		Datacenter: sResWithPrimaryIP.Datacenter,
+		Image:      sResWithPrimaryIP.Image,
+		SSHKeys:    sResWithPrimaryIP.SSHKeys,
+		Networks:   sResWithPrimaryIP.Networks,
 		PublicNet: map[string]interface{}{
 			"ipv4_enabled": true,
 			"ipv4":         primaryIPv4Res.TFID() + ".id",
@@ -615,24 +616,24 @@ func TestServerResource_PrimaryIPNetworkTests(t *testing.T) {
 	sResWithTwoPrimaryIPs.SetRName(sResWithTwoPrimaryIPs.Name)
 
 	sResWithNoPublicNet := &server.RData{
-		Name:         sResWithTwoPrimaryIPs.Name,
-		Type:         sResWithTwoPrimaryIPs.Type,
-		LocationName: sResWithTwoPrimaryIPs.LocationName,
-		Image:        sResWithTwoPrimaryIPs.Image,
-		SSHKeys:      sResWithTwoPrimaryIPs.SSHKeys,
-		Networks:     sResWithTwoPrimaryIPs.Networks,
-		DependsOn:    sResWithTwoPrimaryIPs.DependsOn,
+		Name:       sResWithTwoPrimaryIPs.Name,
+		Type:       sResWithTwoPrimaryIPs.Type,
+		Datacenter: sResWithTwoPrimaryIPs.Datacenter,
+		Image:      sResWithTwoPrimaryIPs.Image,
+		SSHKeys:    sResWithTwoPrimaryIPs.SSHKeys,
+		Networks:   sResWithTwoPrimaryIPs.Networks,
+		DependsOn:  sResWithTwoPrimaryIPs.DependsOn,
 	}
 
 	sResWithNoPublicNet.SetRName(sResWithNoPublicNet.Name)
 
 	sResWithOnlyIPv6 := &server.RData{
-		Name:         sResWithNoPublicNet.Name,
-		Type:         sResWithNoPublicNet.Type,
-		LocationName: sResWithNoPublicNet.LocationName,
-		Image:        sResWithNoPublicNet.Image,
-		SSHKeys:      sResWithNoPublicNet.SSHKeys,
-		Networks:     sResWithNoPublicNet.Networks,
+		Name:       sResWithNoPublicNet.Name,
+		Type:       sResWithNoPublicNet.Type,
+		Datacenter: sResWithNoPublicNet.Datacenter,
+		Image:      sResWithNoPublicNet.Image,
+		SSHKeys:    sResWithNoPublicNet.SSHKeys,
+		Networks:   sResWithNoPublicNet.Networks,
 		PublicNet: map[string]interface{}{
 			"ipv4_enabled": false,
 			"ipv6_enabled": true,
@@ -644,12 +645,12 @@ func TestServerResource_PrimaryIPNetworkTests(t *testing.T) {
 	sResWithOnlyIPv6.SetRName(sResWithOnlyIPv6.Name)
 
 	sResWithOnlyIPv6AutoGenerated := &server.RData{
-		Name:         sResWithOnlyIPv6.Name,
-		Type:         sResWithOnlyIPv6.Type,
-		LocationName: sResWithOnlyIPv6.LocationName,
-		Image:        sResWithOnlyIPv6.Image,
-		SSHKeys:      sResWithOnlyIPv6.SSHKeys,
-		Networks:     sResWithOnlyIPv6.Networks,
+		Name:       sResWithOnlyIPv6.Name,
+		Type:       sResWithOnlyIPv6.Type,
+		Datacenter: sResWithOnlyIPv6.Datacenter,
+		Image:      sResWithOnlyIPv6.Image,
+		SSHKeys:    sResWithOnlyIPv6.SSHKeys,
+		Networks:   sResWithOnlyIPv6.Networks,
 		PublicNet: map[string]interface{}{
 			"ipv4_enabled": false,
 			"ipv6_enabled": true,