test: overriding test images or location using env vars (#851)

This allows us to reduce the pressure on some locations, or override an
image if needed.

Author: jooola

internal/e2etests/image/data_source_test.go

@@ -12,18 +12,15 @@ import (
 	"github.com/hetznercloud/terraform-provider-hcloud/internal/testtemplate"
 )
 
-const TestImageName = e2etests.TestImage
-const TestImageID = "15512617"
-
 func TestAccHcloudDataSourceImageTest(t *testing.T) {
 	tmplMan := testtemplate.Manager{}
 
 	imageByName := &image.DData{
-		ImageName: TestImageName,
+		ImageName: e2etests.TestImage,
 	}
 	imageByName.SetRName("image_by_name")
 	imageByID := &image.DData{
-		ImageID: TestImageID,
+		ImageID: e2etests.TestImageID,
 	}
 	imageByID.SetRName("image_by_id")
 
@@ -40,12 +37,12 @@ func TestAccHcloudDataSourceImageTest(t *testing.T) {
 
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr(imageByName.TFID(),
-						"name", TestImageName),
-					resource.TestCheckResourceAttr(imageByName.TFID(), "id", TestImageID),
+						"name", e2etests.TestImage),
+					resource.TestCheckResourceAttr(imageByName.TFID(), "id", e2etests.TestImageID),
 
 					resource.TestCheckResourceAttr(imageByID.TFID(),
-						"name", TestImageName),
-					resource.TestCheckResourceAttr(imageByID.TFID(), "id", TestImageID),
+						"name", e2etests.TestImage),
+					resource.TestCheckResourceAttr(imageByID.TFID(), "id", e2etests.TestImageID),
 				),
 			},
 		},
@@ -56,7 +53,7 @@ func TestAccHcloudDataSourceImageWithFiltersTest(t *testing.T) {
 	tmplMan := testtemplate.Manager{}
 
 	imageByName := &image.DData{
-		ImageName:         TestImageName,
+		ImageName:         e2etests.TestImage,
 		Architecture:      "arm",
 		IncludeDeprecated: true,
 	}
@@ -74,7 +71,7 @@ func TestAccHcloudDataSourceImageWithFiltersTest(t *testing.T) {
 
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr(imageByName.TFID(),
-						"name", TestImageName),
+						"name", e2etests.TestImage),
 					resource.TestCheckResourceAttr(imageByName.TFID(),
 						"architecture", "arm"),
 				),
@@ -101,8 +98,8 @@ func TestAccHcloudDataSourceImageListTest(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckTypeSetElemNestedAttrs(allImagesSel.TFID(), "images.*",
 						map[string]string{
-							"name": TestImageName,
-							"id":   TestImageID,
+							"name": e2etests.TestImage,
+							"id":   e2etests.TestImageID,
 						},
 					),
 				),

internal/e2etests/server/resource_test.go

@@ -450,7 +450,7 @@ func TestServerResource_PrimaryIPNetworkTests(t *testing.T) {
 		Name:         "primaryip-v4-test",
 		Type:         "ipv4",
 		Labels:       nil,
-		Datacenter:   "hel1-dc2",
+		Datacenter:   e2etests.TestDataCenter,
 		AssigneeType: "server",
 		AutoDelete:   false,
 	}
@@ -460,7 +460,7 @@ func TestServerResource_PrimaryIPNetworkTests(t *testing.T) {
 		Name:         "primaryip-v6-test",
 		Type:         "ipv6",
 		Labels:       nil,
-		Datacenter:   "hel1-dc2",
+		Datacenter:   e2etests.TestDataCenter,
 		AssigneeType: "server",
 		AutoDelete:   false,
 	}

internal/e2etests/testing.go

@@ -11,24 +11,27 @@ import (
 	tfhcloud "github.com/hetznercloud/terraform-provider-hcloud/hcloud"
 )
 
-const (
+var (
 	// TestImage is the system image that is used in all tests
-	TestImage = "ubuntu-20.04"
+	TestImage = getEnv("TEST_IMAGE", "ubuntu-22.04")
+
+	// TestImage is the system image ID that is used in all tests
+	TestImageID = getEnv("TEST_IMAGE_ID", "67794396")
 
 	// TestServerType is the default server type used in all tests
-	TestServerType = "cx11"
+	TestServerType = getEnv("TEST_SERVER_TYPE", "cx11")
 
 	// TestArchitecture is the default architecture used in all tests, should match the architecture of the TestServerType.
-	TestArchitecture = hcloud.ArchitectureX86
+	TestArchitecture = getEnv("TEST_ARCHITECTURE", string(hcloud.ArchitectureX86))
 
 	// TestLoadBalancerType is the default Load Balancer type used in all tests
 	TestLoadBalancerType = "lb11"
 
 	// TestDataCenter is the default datacenter where we execute our tests.
-	TestDataCenter = "hel1-dc2"
+	TestDataCenter = getEnv("TEST_DATACENTER", "nbg1-dc3")
 
 	// TestLocationName is the default location where we execute our tests.
-	TestLocationName = "hel1"
+	TestLocationName = getEnv("TEST_LOCATION", "nbg1")
 )
 
 func ProtoV6ProviderFactories() map[string]func() (tfprotov6.ProviderServer, error) {
@@ -55,3 +58,10 @@ func PreCheck(t *testing.T) func() {
 		}
 	}
 }
+
+func getEnv(key, fallback string) string {
+	if value, ok := os.LookupEnv(key); ok {
+		return value
+	}
+	return fallback
+}