feat(load-balancer): emit warning if unsupported port protocol is configured (#828)

If an unsupported port protocol is configured a warning event and log
message is emitted.

Author: lukasmetzner

internal/hcops/load_balancer.go

@@ -866,6 +866,21 @@ func (l *LoadBalancerOps) ReconcileHCLBServices(
 		portExists := hclbListenPorts[portNo]
 		delete(hclbListenPorts, portNo)
 
+		if port.Protocol != "" && port.Protocol != corev1.ProtocolTCP {
+			warnMsg := fmt.Sprintf(
+				"configured unsupported Hetzner Cloud load balancer protocol %s for service with name %s",
+				port.Protocol,
+				svc.Name,
+			)
+			l.Recorder.Event(
+				svc,
+				corev1.EventTypeWarning,
+				"UnsupportedProtocolConfigured",
+				warnMsg,
+			)
+			klog.Warning(warnMsg)
+		}
+
 		b := &hclbServiceOptsBuilder{Port: port, Service: svc, CertOps: l.CertOps}
 		if portExists {
 			klog.InfoS("update service", "op", op, "port", portNo, "loadBalancerID", lb.ID)

internal/hcops/load_balancer_test.go

@@ -1448,6 +1448,48 @@ func TestLoadBalancerOps_ReconcileHCLBTargets(t *testing.T) {
 
 func TestLoadBalancerOps_ReconcileHCLBServices(t *testing.T) {
 	tests := []LBReconcilementTestCase{
+		{
+			name: "configure unsupported protocol",
+			servicePorts: []corev1.ServicePort{
+				{Port: 80, NodePort: 8080, Protocol: corev1.ProtocolUDP},
+				{Port: 443, NodePort: 8443, Protocol: corev1.ProtocolUDP},
+			},
+			initialLB: &hcloud.LoadBalancer{
+				ID: 4,
+				LoadBalancerType: &hcloud.LoadBalancerType{
+					MaxTargets: 25,
+				},
+			},
+			mock: func(_ *testing.T, tt *LBReconcilementTestCase) {
+				opts := hcloud.LoadBalancerAddServiceOpts{
+					Protocol:        hcloud.LoadBalancerServiceProtocolTCP,
+					ListenPort:      hcloud.Ptr(80),
+					DestinationPort: hcloud.Ptr(8080),
+					HealthCheck: &hcloud.LoadBalancerAddServiceOptsHealthCheck{
+						Protocol: hcloud.LoadBalancerServiceProtocolTCP,
+						Port:     hcloud.Ptr(8080),
+					},
+				}
+				action := tt.fx.MockAddService(opts, tt.initialLB, nil)
+				tt.fx.ActionClient.On("WaitFor", tt.fx.Ctx, action).Return(nil)
+
+				opts = hcloud.LoadBalancerAddServiceOpts{
+					Protocol:        hcloud.LoadBalancerServiceProtocolTCP,
+					ListenPort:      hcloud.Ptr(443),
+					DestinationPort: hcloud.Ptr(8443),
+					HealthCheck: &hcloud.LoadBalancerAddServiceOptsHealthCheck{
+						Protocol: hcloud.LoadBalancerServiceProtocolTCP,
+						Port:     hcloud.Ptr(8443),
+					},
+				}
+				action = tt.fx.MockAddService(opts, tt.initialLB, nil)
+				tt.fx.ActionClient.On("WaitFor", tt.fx.Ctx, action).Return(nil)
+			},
+			perform: func(t *testing.T, tt *LBReconcilementTestCase) {
+				_, err := tt.fx.LBOps.ReconcileHCLBServices(tt.fx.Ctx, tt.initialLB, tt.service)
+				assert.NoError(t, err)
+			},
+		},
 		{
 			name: "add services to hc Load Balancer",
 			servicePorts: []corev1.ServicePort{