Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid native dependencies #184

Open
msakrejda opened this issue Apr 3, 2018 · 7 comments
Open

Avoid native dependencies #184

msakrejda opened this issue Apr 3, 2018 · 7 comments
Assignees

Comments

@msakrejda
Copy link
Contributor

These regularly cause issues for us as it vastly complicates the CLI plugin installation process.

@jdx
Copy link
Contributor

jdx commented Apr 4, 2018

Bad news is this has 4 test failures for me locally, but I get those same failures on master so I think this should work: hunterloftis/kafka#4

@msakrejda
Copy link
Contributor Author

@jdxcode huh what failures do you get locally? Runs fine for me...

@jdx
Copy link
Contributor

jdx commented Apr 4, 2018

I definitely don't think they're related, but I'll get the output

@msakrejda
Copy link
Contributor Author

Also master runs fine, but on your branch (after running yarn and even rm -rf node_modules && yarn), I get failures like

  1) kafka:topics:tail warns and exits with an error if used with a Private Spaces cluster:

      AssertionError: expected 'Cannot find module \'snappy\'' to equal '`kafka:topics:tail` is not available in Heroku Private Spaces'
      + expected - actual

      -Cannot find module 'snappy'
      +`kafka:topics:tail` is not available in Heroku Private Spaces

@jdx
Copy link
Contributor

jdx commented Apr 4, 2018

@msakrejda
Copy link
Contributor Author

Huh

@msakrejda
Copy link
Contributor Author

Ok, after working out the yarn issues as per our Slack discussion, tests pass for me locally and a simple kafka:write / kafka:tail test with a live cluster works fine. I think we should give this a shot.

@msakrejda msakrejda removed their assignment Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants