Handle Rails 4 apps without sprockets-rails #867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building a Rails 4 without `sprockets-rails`, asset compilation is assumed to always be enabled, which would then cause an exception to be raised when trying to determine whether the `sprockets` version is vulnerable to CVE-2018-3760. This commit ensures that Asset Compilation is properly detected as being disabled when the `sprockets-rails` Gem is absent. Closes heroku#866.
|
Sprockets-rails is a hard dependency of Rails 4 https://rubygems.org/gems/rails/versions/4.2.11.1 |
|
It is indeed a hard-dependency of Rails, but Rails detection is not looking for the My first approach was to change the detection to look for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a Rails 4 without
sprockets-rails, asset compilation is assumed to always be enabled, which would then cause an exception to be raised when trying to determine whether thesprocketsversion is vulnerable to CVE-2018-3760.This PR ensures that Asset Compilation is properly detected as being disabled when the
sprockets-railsGem is absent.Closes #866.