Set memory default for Node builds #861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
approved these changes
Mar 8, 2019
schneems
requested changes
May 20, 2019
lib/language_pack/ruby.rb
Outdated
| # | ||
| # This passes an argument to all Node processes during the build, so that they | ||
| # can take advantage of all available memory on the build dynos. | ||
| ENV["NODE_OPTIONS"] ||= "--max_old_space_size=2560" |
There was a problem hiding this comment.
Is this a user set-able option? If so we need to use lowercase env() function instead of ENV.
jmorrell
force-pushed
the
add-node-build-memory-default
branch
from
83f45b7 to
bfaefb6
Compare
schneems
approved these changes
May 22, 2019
schneems
force-pushed
the
add-node-build-memory-default
branch
from
15d0098 to
a440cae
Compare
schneems
force-pushed
the
add-node-build-memory-default
branch
from
a440cae to
b4f9c0f
Compare
schneems
force-pushed
the
add-node-build-memory-default
branch
from
b4f9c0f to
a3c97e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #859
My attempt at trying to address #859. I'm mostly guessing how to do this and happy to revise.