Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--json shows update messages #1736

Open
brendanfalk opened this issue Feb 8, 2021 · 2 comments
Open

--json shows update messages #1736

brendanfalk opened this issue Feb 8, 2021 · 2 comments

Comments

@brendanfalk
Copy link

Bug
image

What is the current behavior?

When using the --json flag (such as in the example above) Heroku shows update messages.

What is the expected behavior?

It should not output update messages. Why? I would think that the vast majority of the time when someone uses --json they are intending to pipe the output into something like jq. However, when the update message is present, the output string is not valid json

@fivetanley
Copy link
Contributor

Hi,

The Heroku CLI outputs should be outputting this warning on STDERR, not STDOUT. This allows us to display the error, while keeping something like heroku apps --all --json | jq . working. While it is a bit confusing, I think this is intended behaviour.

Have you noticed this breaking any scripts for you? It may be possible we're emitting a warning over stdout when we should be emitting over stderr

@brendanfalk
Copy link
Author

Yes - we run that shell command in what I believe is a non-login process and it still outputs the warning... I can't reproduce anymore as I updated the CLI...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants