Skip to content

Commit 6245f25

Browse files
committed
Apply contributing review feedback
1 parent f1baa65 commit 6245f25

File tree

1 file changed

+3
-18
lines changed

1 file changed

+3
-18
lines changed

CONTRIBUTING.md

+3-18
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,8 @@ Fixes, improvements, and patches all happen via [GitHub Pull Requests on this re
3232

3333
This buildpack relies on [heroku/libcnb.rs][libcnb] to compile buildpacks. All [libcnb.rs dependencies][libcnb-deps] will need to be setup prior to building or testing this buildpack.
3434

35-
1. Install [rust by following instructions on their site](https://www.rust-lang.org/tools/install)
36-
1. Follow the setup instructions on [heroku/libcnb](https://github.com/heroku/libcnb.rs)
37-
1. Install the [pack cli](https://buildpacks.io/docs/for-platform-operators/how-to/integrate-ci/pack/)
35+
1. Install [rust by following instructions on their site][install-rust]
36+
1. Follow the setup instructions on [heroku/libcnb][libcnb-deps]
3837

3938
### Building the buildpack locally
4039

@@ -103,21 +102,6 @@ docker run -it --rm --env PORT=9292 -p 9292:9292 my-image
103102
pack inspect my-image
104103
```
105104

106-
Depending on the development situation you may need to manually instruct docker to use the CNB entrypoint. You can do that by passing `--entrypoint='/cnb/lifecycle/launcher` to your docker command.
107-
108-
Here is a command for building and running an image in one step with a clean cache:
109-
110-
```
111-
export IMAGE_NAME=ruby-buildpack-example &&
112-
cargo libcnb package &&
113-
docker rmi "$IMAGE_NAME" --force &&
114-
pack build "$IMAGE_NAME" \
115-
--buildpack packaged/x86_64-unknown-linux-musl/debug/heroku_ruby \
116-
--path buildpacks/ruby/tests/fixtures/default_ruby \
117-
--verbose &&
118-
docker run -it --rm --entrypoint='/cnb/lifecycle/launcher' "$IMAGE_NAME" 'which bundle'
119-
```
120-
121105
### Testing
122106

123107
- `cargo test` performs Rust unit tests.
@@ -135,6 +119,7 @@ By contributing your code, you agree to license your contribution under the term
135119

136120
[cnb]: https://buildpacks.io
137121
[discussions]: https://github.com/heroku/buildpacks/discussions
122+
[install-rust]: https://www.rust-lang.org/tools/install
138123
[issues]: https://github.com/heroku/buildpacks-ruby/issues
139124
[libcnb]: https://github.com/heroku/libcnb.rs
140125
[libcnb-deps]: https://github.com/heroku/libcnb.rs#development-environment-setup

0 commit comments

Comments
 (0)