feat: Fast stdin display, lower memory usage, follow/reverse mode, home/end key support. long help support #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedhyw
reviewed
Aug 21, 2024
|
I'm still on it, need more time |
hedhyw
reviewed
Aug 30, 2024
There was a problem hiding this comment.
- suggestion: there are many complex changes, can we extend tests? I can help with it, and yes, it's possible to do in another PR.
- note: I'll try to use it for a week for manual testing.
todo: the PR title should be:
"feat: Fast stdin display, lower memory usage, follow/reverse mode, home/end key support. long help support"
it will fix:
- todo: please also include "
Closes #52, #64, #79" in the PR description. - praise: nice, thank you for your pull request.
…on string Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
…of stdin fed logs. Log lines are not kept in memory anymore, we now just hold keep an offset, length for each line. Reload feature dropped since we now display stdin updates as soon as they are available.
Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
Co-authored-by: Maksym Kryvchun <hedhyw@yahoo.com>
Co-authored-by: Maksym Kryvchun <hedhyw@yahoo.com>
Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
|
Rebased and applied your suggestions. I'll be able to look into this more next week. |
hedhyw
changed the title
Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
|
Fixed the linter warnings. Let me know if there are any other bits you want adjusted. |
|
the test coverage decreased significantly, I can help with tests here |
|
The latest changes don't work for me.
commit 88a3750 |
hedhyw
reviewed
Sep 12, 2024
Co-authored-by: Maksym Kryvchun <hedhyw@yahoo.com> Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
Broke in ec18c3c Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
|
That break is fixed now. |
hedhyw
approved these changes
Sep 16, 2024
Closed
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe I got a little carried away. It would have been better if this was done over several commits. Feel free to cherry-pick ideas from this PR if you like any of its features.
The main reason I started down this path was that I expected
docker logs XXX -f | jlvto behave similarly totail -fwith lo events just showing up as they occurred. With this PR, stdin input is displayed instantly. The log table now has a follow mode which is turned off once you navigate away from the latest log entry so the log entries will stop scrolling past the window.While at it I noticed that we could optimize memory use by NOT holding log line data in memory. We just need an offset, and length pair for each long line. When the log is displayed we just load it back from the file. Maybe we should increase the default MAX file size setting? Might need some testing to figure out a better default.
If you have a fast log stream, it might be hard to get back into follow mode by pressing the up key enough times to go past the first item, so Home/End key support was added.
And while at it, I reversed log file order and option. pressing r will toggle.
With so many new options, and mode, I added support for long help display. Press ? to show the more advanced key binds.