-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It froze our production server while reading a 288MB log file #64
Comments
Ohhh, I'm sorry to hear. I hope this didn't have any big consequences. I will add some reasonable limit until stream reading is done: #55 |
Big memory & CPU optimization included in https://github.com/hedhyw/json-log-viewer/releases/tag/v0.4.0 What changed:
Please confirm that v0.4.0 works for you as expected! |
I tried with version v0.4.0 and it still froze the whole server. I am using a staging server this time :) PS: is there any help or version command? |
Good idea. I will add a version command. Did you see "reloading..." when you pressed up? Was level "INFO"? Was loading fast? Please, check the video: |
fixed in #85 |
I installed this log viewer on our production server after switching to
pino
for logging.It took a moment to to load but it eventually loaded. I checked a couple of entries and pressed
up
to reload the file.I was waiting for the file to load but I got a notification from our monitoring service that the production api server was down. I logged in to AWS to reboot the server from their EC2 dashboard. We were back online after 12 min.
300 MB is not huge for a log file. Even if it cannot handle big files, it might be good to have some check/limits and crash with a message rather than clog the whole system.
The text was updated successfully, but these errors were encountered: