Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverse Hyperbolic Sine Transformation Was Applied to DWPCs Reported on the Connectivity Search Website #177

Open
NegarJanani opened this issue Jul 2, 2024 · 4 comments

Comments

@NegarJanani
Copy link

NegarJanani commented Jul 2, 2024

When I was trying to reproduce the code, I found that the DWPCs I calculated using the hetnetpy repository differed from those in the connectivity search website. Upon further investigation of the code in connectivity-search-analyses/explore, I discovered that an inverse hyperbolic sine transformation was applied to the DWPCs, accounting for the difference.

This transformation makes sense because it can reduce the influence of outliers in a right-skewed distribution. Since DWPCs are sparse, it helps fit the Gamma-hurdle distribution to the data and find p-values using the Gamma-hurdle distribution as the null distribution.

After discussing with @cgreene, he believes it would be useful to mention this both here and in the connectivity-search-frontend repository.

@dhimmel
Copy link
Collaborator

dhimmel commented Jul 2, 2024

Hey @NegarJanani. Wondering if you can provide a comment in addition to the title.

@NegarJanani
Copy link
Author

Hey @NegarJanani. Wondering if you can provide a comment in addition to the title.

Hi @dhimmel I will update it soon :)

@NegarJanani NegarJanani changed the title Inverse Hyperbolic Sin transformation applied on DWPCs Reported in Connectivity Search Website Inverse Hyperbolic Sine Transformation Was Applied to DWPCs Reported on the Connectivity Search Website Jul 2, 2024
@dhimmel
Copy link
Collaborator

dhimmel commented Jul 3, 2024

Thanks @NegarJanani for helping clarify the documentation. I agree the webapp should note if the DWPCs are transformed or not. I believe the DWPCs shows in the webapp are transformed due to:

Quoting from the manuscript:

Rather than using the raw DWPC for a source–metapath–target combination, we transform the DWPC across all source–target node pairs for a metapath to yield a distribution that is more compact and amenable to modeling [31].

And this line of code in the API. Do we also need to update the description for this API field?

@NegarJanani
Copy link
Author

this API field

I think it would be useful to update the API as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants