Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Vale configuration example #951

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Update Vale configuration example #951

merged 2 commits into from
Jan 29, 2025

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented Jan 14, 2025 •
edited
Loading

I need to also update the steps to tell a user to run vale sync after updating the repository

  • I've used a relevant pull request (PR) title.
  • I've added a link to any relevant issues in the PR description.
  • I've checked my changes on the deploy preview and they look good.
  • I've added an entry to the What's new page (only required for notable changes).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

💻 Deploy preview deleted.

@clayton-cornell
Copy link
Contributor

clayton-cornell commented Jan 14, 2025 •
edited
Loading

I had to do a <PATH>/vale --config='<PATH>/vale.ini sync to get vale working with this updated vale.ini. (I included because vale binary and vale.ini are not in my system path :-P )

@jdbaldry
Update Vale configuration example
3573b11 
I need to also update the steps to tell a user to run `vale sync`
@jdbaldry
Add step for running vale sync
8a2554d 
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry jdbaldry requested a review from imatwawana January 29, 2025 11:53
@jdbaldry jdbaldry marked this pull request as ready for review January 29, 2025 11:53
@jdbaldry jdbaldry merged commit 2a8ec72 into main Jan 29, 2025
8 checks passed
@jdbaldry jdbaldry deleted the jdbaldry-patch-2 branch January 29, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chri2547 chri2547 chri2547 approved these changes

@imatwawana imatwawana imatwawana approved these changes

@clayton-cornell clayton-cornell Awaiting requested review from clayton-cornell clayton-cornell is a code owner

@knylander-grafana knylander-grafana Awaiting requested review from knylander-grafana knylander-grafana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdbaldry @clayton-cornell @chri2547 @imatwawana