Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add examples to screenshot guidelines #1050

Merged
merged 10 commits into from
Feb 19, 2025

Conversation

imatwawana
Copy link
Contributor

No description provided.

@imatwawana imatwawana added the type/docs Docs Squad label used across all Grafana Labs repos label Feb 14, 2025
@imatwawana imatwawana self-assigned this Feb 14, 2025
Copy link
Contributor

github-actions bot commented Feb 14, 2025

💻 Deploy preview deleted.

Copy link
Contributor

@robbymilo robbymilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise great!

Comment on lines 149 to 150
Good example of size at 545 pixels wide:
![Good size example](/media/docs/grafana/panels-visualizations/screenshot-stat-single-value-v11.3.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this image looks a little blurry on high dpi screens.

In this case I would suggest a file that is 2x resolution, or 1090px wide, and then limited to 545px wide with the figure shortcode's max-width argument.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to pick your brain a bit about this offline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the image and booked a meeting with you to go over my confusion around this stuff!

Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@imatwawana imatwawana merged commit aef474d into main Feb 19, 2025
8 checks passed
@imatwawana imatwawana deleted the ihm/310124-add-screenshot-examples branch February 19, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Docs Squad label used across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants