Skip to content

Commit ccc2bcf

Browse files
authored
Removes AWS and Azure cloud resource detectors (#114)
1 parent 03d753a commit ccc2bcf

9 files changed

+44
-10
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
### BREAKING CHANGES
66

7+
* Removes AWS and Azure resource detectors.
8+
([#114](https://github.com/grafana/grafana-opentelemetry-dotnet/pull/114))
79
* Drops supports for .NET 7. EOL was May 24 2024
810
([#116](https://github.com/grafana/grafana-opentelemetry-dotnet/pull/116))
911
* Separates resource detectors and instrumentations. Removes resource detector

src/Grafana.OpenTelemetry.Base/Grafana.OpenTelemetry.Base.csproj

-3
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,10 @@
4343
<PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="1.9.0" />
4444
<PackageReference Include="OpenTelemetry.Instrumentation.Process" Version="0.5.0-beta.6" />
4545
<PackageReference Include="OpenTelemetry.Instrumentation.SqlClient" Version="1.9.0-beta.1" />
46-
47-
<PackageReference Include="OpenTelemetry.Resources.Azure" Version="1.0.0-beta.8" />
4846
</ItemGroup>
4947

5048
<!-- Non-stable instrumentation packages with no dependencies, non netstandard2.0 -->
5149
<ItemGroup Condition=" '$(TargetFramework)' != 'netstandard2.0' ">
52-
<PackageReference Include="OpenTelemetry.Resources.AWS" Version="1.5.0-beta.1" />
5350
<PackageReference Include="OpenTelemetry.Resources.Host" Version="0.1.0-beta.2" />
5451
<PackageReference Include="OpenTelemetry.Resources.OperatingSystem" Version="0.1.0-alpha.2" />
5552
<PackageReference Include="OpenTelemetry.Resources.Process" Version="0.1.0-beta.2" />

src/Grafana.OpenTelemetry.Base/ResourceDetectors/AWSEBSDetectorInitializer.cs

+6-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,12 @@ internal class AWSEBSDetectorInitializer : ResourceDetectorInitializer
1414

1515
protected override ResourceBuilder InitializeResourceDetector(ResourceBuilder builder)
1616
{
17-
return builder.AddAWSEBSDetector();
17+
ReflectionHelper.CallStaticMethod(
18+
"OpenTelemetry.Resources.AWS",
19+
"OpenTelemetry.Resources.AWSResourceBuilderExtensions",
20+
"AddAWSEBSDetector",
21+
new object[] { builder });
22+
return builder;
1823
}
1924
}
2025
}

src/Grafana.OpenTelemetry.Base/ResourceDetectors/AWSEC2DetectorInitializer.cs

+6-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,12 @@ internal class AWSEC2DetectorInitializer : ResourceDetectorInitializer
1414

1515
protected override ResourceBuilder InitializeResourceDetector(ResourceBuilder builder)
1616
{
17-
return builder.AddAWSEC2Detector();
17+
ReflectionHelper.CallStaticMethod(
18+
"OpenTelemetry.Resources.AWS",
19+
"OpenTelemetry.Resources.AWSResourceBuilderExtensions",
20+
"AddAWSEC2Detector",
21+
new object[] { builder });
22+
return builder;
1823
}
1924
}
2025
}

src/Grafana.OpenTelemetry.Base/ResourceDetectors/AWSECSDetectorInitializer.cs

+6-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,12 @@ internal class AWSECSDetectorInitializer : ResourceDetectorInitializer
1414

1515
protected override ResourceBuilder InitializeResourceDetector(ResourceBuilder builder)
1616
{
17-
return builder.AddAWSECSDetector();
17+
ReflectionHelper.CallStaticMethod(
18+
"OpenTelemetry.Resources.AWS",
19+
"OpenTelemetry.Resources.AWSResourceBuilderExtensions",
20+
"AddAWSECSDetector",
21+
new object[] { builder });
22+
return builder;
1823
}
1924
}
2025
}

src/Grafana.OpenTelemetry.Base/ResourceDetectors/AWSEKSDetectorInitializer.cs

+6-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,12 @@ internal class AWSEKSDetectorInitializer : ResourceDetectorInitializer
1414

1515
protected override ResourceBuilder InitializeResourceDetector(ResourceBuilder builder)
1616
{
17-
return builder.AddAWSEKSDetector();
17+
ReflectionHelper.CallStaticMethod(
18+
"OpenTelemetry.Resources.AWS",
19+
"OpenTelemetry.Resources.AWSResourceBuilderExtensions",
20+
"AddAWSEKSDetector",
21+
new object[] { builder });
22+
return builder;
1823
}
1924
}
2025
}

src/Grafana.OpenTelemetry.Base/ResourceDetectors/AzureAppServiceDetectorInitializer.cs

+6-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,12 @@ internal class AzureAppServiceDetectorInitializer : ResourceDetectorInitializer
1313

1414
protected override ResourceBuilder InitializeResourceDetector(ResourceBuilder builder)
1515
{
16-
return builder.AddAzureAppServiceDetector();
16+
ReflectionHelper.CallStaticMethod(
17+
"OpenTelemetry.Resources.Azure",
18+
"OpenTelemetry.Resources.AzureResourceBuilderExtensions",
19+
"AddAzureAppServiceDetector",
20+
new object[] { builder });
21+
return builder;
1722
}
1823
}
1924
}

src/Grafana.OpenTelemetry.Base/ResourceDetectors/AzureContainerAppsDetectorInitializer.cs

+6-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,12 @@ internal class AzureContainerAppsDetectorInitializer : ResourceDetectorInitializ
1313

1414
protected override ResourceBuilder InitializeResourceDetector(ResourceBuilder builder)
1515
{
16-
return builder.AddAzureContainerAppsDetector();
16+
ReflectionHelper.CallStaticMethod(
17+
"OpenTelemetry.Resources.Azure",
18+
"OpenTelemetry.Resources.AzureResourceBuilderExtensions",
19+
"AddAzureContainerAppsDetector",
20+
new object[] { builder });
21+
return builder;
1722
}
1823
}
1924
}

src/Grafana.OpenTelemetry.Base/ResourceDetectors/AzureVMDetectorInitializer.cs

+6-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,12 @@ internal class AzureVMDetectorInitializer : ResourceDetectorInitializer
1313

1414
protected override ResourceBuilder InitializeResourceDetector(ResourceBuilder builder)
1515
{
16-
return builder.AddAzureVMDetector();
16+
ReflectionHelper.CallStaticMethod(
17+
"OpenTelemetry.Resources.Azure",
18+
"OpenTelemetry.Resources.AzureResourceBuilderExtensions",
19+
"AddAzureVMDetector",
20+
new object[] { builder });
21+
return builder;
1722
}
1823
}
1924
}

0 commit comments

Comments
 (0)