From 4836de71702e5c89f0e6d0a0c4223592ad97b5fe Mon Sep 17 00:00:00 2001 From: "Guillermo N." Date: Mon, 7 Oct 2024 03:09:22 +0200 Subject: [PATCH 1/2] Refactor TestValidBrowsers. Signed-off-by: Guillermo N. --- internal/jsonapi/manifest/setup_test.go | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/internal/jsonapi/manifest/setup_test.go b/internal/jsonapi/manifest/setup_test.go index 9865f2f..a5607a9 100644 --- a/internal/jsonapi/manifest/setup_test.go +++ b/internal/jsonapi/manifest/setup_test.go @@ -50,12 +50,18 @@ func TestValidBrowser(t *testing.T) { func TestValidBrowsers(t *testing.T) { t.Parallel() - validBrowsers := []string{"brave", "chrome", "chromium", "firefox", "iridium", "slimjet", "vivaldi"} - if runtime.GOOS == "windows" { + var validBrowsers []string + + switch runtime.GOOS { + case "darwin": // macOS + validBrowsers = []string{"arc", "brave", "chrome", "chromium", "firefox", "iridium", "slimjet", "vivaldi"} + case "windows": // Windows validBrowsers = []string{"chrome", "chromium", "firefox"} + case "linux": // Linux + validBrowsers = []string{"brave", "chrome", "chromium", "firefox", "iridium", "slimjet", "vivaldi"} + default: // Fallback, not suppoerted OS + t.Fatalf("Unsupported OS: %s", runtime.GOOS) } - if runtime.GOOS == "darwin" { - validBrowsers = append(validBrowsers, "arc") - } - assert.ElementsMatch(t, validBrowsers, ValidBrowsers()) -} + + assert.Equal(t, validBrowsers, ValidBrowsers()) +} \ No newline at end of file From 242e197f852350f4e7b66571f9ef8c31d56cdafd Mon Sep 17 00:00:00 2001 From: "Guillermo N." Date: Mon, 7 Oct 2024 03:30:58 +0200 Subject: [PATCH 2/2] Fix format setup_test.go Signed-off-by: Guillermo N. --- internal/jsonapi/manifest/setup_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/jsonapi/manifest/setup_test.go b/internal/jsonapi/manifest/setup_test.go index a5607a9..b4643b0 100644 --- a/internal/jsonapi/manifest/setup_test.go +++ b/internal/jsonapi/manifest/setup_test.go @@ -64,4 +64,4 @@ func TestValidBrowsers(t *testing.T) { } assert.Equal(t, validBrowsers, ValidBrowsers()) -} \ No newline at end of file +}