init repo #1
Open
init repo #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmasclef
reviewed
Dec 13, 2019
rmasclef
approved these changes
Dec 14, 2019
rmasclef
reviewed
Dec 14, 2019
| ) | ||
|
|
||
| type MyObject struct { | ||
| *workflow.Marking |
There was a problem hiding this comment.
I'm still not OK with that coupling 😭
There was a problem hiding this comment.
- You still not give an alternative instead of crying..
- You still not read the code!!!
i advise you to read https://github.com/gol4ng/workflow/pull/1/files#diff-def19e92a3bab12d9d1c3ac803fb7accR7
that allow you to implement your own marking storer and let you store marking information outside of subject if you want
instabledesign
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.