Skip to content

Commit bb8d38d

Browse files
authored
fix(demangle): Unbreak GitHub Action Windows builds (#891)
The 12.13.0 release and pull request #885 specifically broke GitHub Action based Windows builds. The reason seems to be that the Swift library upgrade now relies on C++17 features and the GitHub Actions Windows image uses MSVC 2022, which requires an explicit opt-in to those. The provided -std=c++17 works on GCC and similar, but does not have any effect on MSVC. To fix the build, add the flag that MSVC understands for opting in to the new standard.
1 parent ffd1ec5 commit bb8d38d

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

CHANGELOG.md

+9-4
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,21 @@
22

33
## Unreleased
44

5-
- Fix new clippy lints ([#889](https://github.com/getsentry/symbolic/pull/889))
6-
- Run `cargo update` ([#888](https://github.com/getsentry/symbolic/pull/888))
5+
**Fixes**
6+
7+
- Fixed GHA-based Windows builds ([#891](https://github.com/getsentry/symbolic/pull/891)).
78

89
## 12.13.1
910

11+
**Fixes**
12+
1013
- Fixed a compilation issue with older GCC compilers. ([#886](https://github.com/getsentry/symbolic/pull/886))
1114

1215
## 12.13.0
1316

14-
- Update libswift demangle to v6.0.3. ([#885](https://github.com/getsentry/symbolic/pull/885))
17+
**Features**
18+
19+
- Updated libswift demangle to v6.0.3. ([#885](https://github.com/getsentry/symbolic/pull/885))
1520

1621
## 12.12.4
1722

@@ -34,7 +39,7 @@
3439

3540
## 12.12.1
3641

37-
**Features**:
42+
**Features**
3843

3944
- feat(js): Sourcemap debug IDs can now be read from the `"debugId"` field in addition to
4045
`"debug_id"` ([#870](https://github.com/getsentry/symbolic/pull/870)).

symbolic-demangle/build.rs

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ fn main() {
1818
"vendor/swift/lib/Demangling/Remangler.cpp",
1919
])
2020
.flag_if_supported("-std=c++17")
21+
.flag_if_supported("/std:c++17")
2122
.flag_if_supported("-fpermissive")
2223
.flag_if_supported("-Wno-changes-meaning")
2324
.flag("-DLLVM_DISABLE_ABI_BREAKING_CHECKS_ENFORCING=1")

0 commit comments

Comments
 (0)