Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering previous release commits based on env #32618

Open
kamilogorek opened this issue Mar 15, 2022 · 3 comments
Open

Allow filtering previous release commits based on env #32618

kamilogorek opened this issue Mar 15, 2022 · 3 comments
Labels

Comments

@kamilogorek
Copy link
Contributor

Problem Statement

Quoting @billyvg:

When using setCommits() with auto: true and multiple environments, you can get into a state where your production releases do not have the right commits because its previous release is not production and does not have any commits (in the release). It would be good if we could look for commits in the previous release of a specific environment.

It's indeed not possible to do that, due to https://github.com/getsentry/sentry/blob/master/src/sentry/api/endpoints/organization_release_previous_commits.py not having this capability. I tried to dig into this, but I don't know the structure well enough to tackle this right now.
I already implemented this on the CLI side, just need the endpoint to return back correct data.

ref: getsentry/sentry-cli#1076
ref: getsentry/action-release#54
sentry-cli implementation: getsentry/sentry-cli#1145

Solution Brainstorm

No response

@sshishov
Copy link

sshishov commented Mar 24, 2022

We are having almost the similar issue. We are also using multiple environments. But our logic is to use finalize ONLY the release which is going to the production environment.

We were really thinking that the commit history SHOULD BE calculated from the previous finalized release until current release (does not matter the environment TBH).

Currently it is not working as expected, even though the README is saying the opposite: https://docs.sentry.io/product/cli/releases/#finalizing-releases

By default a release is created “unreleased”. Finalizing a release means that we fill in a second timestamp on the release record, which is prioritized over date_created when sorting releases in the UI. This also affects what counts as "the next release" for resolving issues, what release is used as the base for associating commits if you use --auto, and creates an entry in the Activity stream.

@github-actions
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@CharlesB2
Copy link

I found a workaround for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants