ignore option on win/mac

getsentry · Feb 24, 2025 · b916ce0 · b916ce0
1 parent 843f501
commit b916ce0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/client/crashpad_client_mac.cc b/client/crashpad_client_mac.cc
@@ -482,7 +482,10 @@ bool CrashpadClient::StartHandler(
     const std::vector<std::string>& arguments,
     bool restartable,
     bool asynchronous_start,
-    const std::vector<base::FilePath>& attachments) {
+    const std::vector<base::FilePath>& attachments,
+    bool wait_for_upload) {
+  (void) wait_for_upload; // unused in mac (for now)
+
   // The “restartable” behavior can only be selected on OS X 10.10 and later. In
   // previous OS versions, if the initial client were to crash while attempting
   // to restart the handler, it would become an unkillable process.

diff --git a/client/crashpad_client_win.cc b/client/crashpad_client_win.cc
@@ -637,7 +637,9 @@ bool CrashpadClient::StartHandler(
     const std::vector<std::string>& arguments,
     bool restartable,
     bool asynchronous_start,
-    const std::vector<base::FilePath>& attachments) {
+    const std::vector<base::FilePath>& attachments,
+    bool wait_for_upload) {
+  (void) wait_for_upload; // unused in win (for now)
   DCHECK(ipc_pipe_.empty());
 
   // Both the pipe and the signalling events have to be created on the main