Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release created without commits and no info on how to move forward #75

Open
duhlin opened this issue Nov 15, 2021 · 7 comments
Open

Release created without commits and no info on how to move forward #75

duhlin opened this issue Nov 15, 2021 · 7 comments
Labels
documentation Improvements or additions to documentation

Comments

@duhlin
Copy link

duhlin commented Nov 15, 2021

Environment

How do you use Sentry?
Sentry SaaS (sentry.io)

Which SDK and version?
getsentry/action-release@v1

Steps to Reproduce

I've followed the intructions to configure getsentry/action-release

  1. I've declared an Internal Integration, with the appropriate permissions (Release - Admin, Organization - Read).
  2. I've edited my github workflow to fetch all commits from all branches on checkout
      - uses: actions/checkout@v2
        with:
          fetch-depth: 0
  1. I've added to my github workflow a step:
     - name: Create Sentry release
        uses: getsentry/action-release@v1
        env:
          SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
          SENTRY_ORG: ${{ secrets.SENTRY_ORG }}
          SENTRY_PROJECT: ${{ secrets.SENTRY_PROJECT }}
        with:
          environment: production
  1. My workflow is scheduled to be executed on commits on the release branch, I've then pushed a few commits.

Expected Result

Release should be created in sentry.io and the related commits should be shown, i.e. the list of new commits, not included in the previous release.

Actual Result

No commit information is shown on sentry.io
image

No log on github action side
image

@amjanoni
Copy link

+1

@FxllenCode
Copy link

Same issue as described above.

@alvarorc
Copy link

Hi guys, for those who still have problems with this, I found in the sentry-cli documentation that it is necessary to add the repository in the github integration. It seams like sentry need to get access to the specific repository for get the commits diff from the previous release.
Also you can specify the code mapping for your source-maps in the same place.

Screen Shot 2022-03-30 at 20 01 31

@armenzg armenzg changed the title Fail to include info about commits Release created without commits and no info on how to move forward Jul 19, 2022
@armenzg
Copy link
Member

armenzg commented Jul 19, 2022

For future reference, this was filed using version 1.6 of this action:
image

Currently, the sentry-cli version in use is 1.67.2

"@sentry/cli": "^1.67.2"

action-release/yarn.lock

Lines 555 to 557 in 426b547

"@sentry/cli@^1.67.2":
version "1.67.2"
resolved "https://registry.yarnpkg.com/@sentry/cli/-/cli-1.67.2.tgz#dbb5631cb3637e10298f67915013592cb22f04ff"

Which was updated in July 2021 which was before this issue was filed.

It would be ideal to have an option to enable debug logging on CI. You can reproduce locally if you have sentry-cli installed on your host and you checkout the same branch:

SENTRY_AUTH_TOKEN= sentry-cli releases --log-level debug set-commits --org <sentry_slug_org> --auto

I'm using the same set up as per @duhlin I have been able to create releases with commits.
image

I have verified that I do not have code mappings for my sentry-github-actions-app repo (as per mentioned by @alvarorc ).

@duhlin do you still face this issue?

@duhlin
Copy link
Author

duhlin commented Aug 27, 2022

Thanks for your help, I've noticed that the configuration for sentry wasn't correct.
I had successfully done the mandatory steps:

  • declare a repository
  • add the integration for github action

For some reason, the integration with github wasn't configured properly. The application was registered and configured properly on github side but not listed as installed on sentry side. I've unregistered the application on github and then added the github integration on sentry.

Now the two integrations are listed:
image
and I'm finally able to collect commit info when publishing a new release.

@mason-1009
Copy link

Hello, everyone. I was having this same issue with a private repository of mine, where Sentry was pushing releases with the Github Action where 20+ commits would be associated with a single commit SHA and the next commit would be empty. I found that this issue was directly caused by using tags instead of SHAs for releases. If you use tags for releases, passing version: ${{ github.ref }} as an input to the release action should fix this problem. Default behavior is to use ${{ github.sha }}.

@smeubank smeubank added the documentation Improvements or additions to documentation label Dec 11, 2024
@smeubank
Copy link
Member

imo: there's partially a docs fix to this problems and we could investigate making the action and product more "clever"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

7 participants