Skip to content

Commit 3420a6b

Browse files
committed
Address reviewer feedback
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
1 parent 89e93bc commit 3420a6b

File tree

3 files changed

+4
-25
lines changed

3 files changed

+4
-25
lines changed

bloom/ros_gz/README.md

-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ Each ROS release defines one version of Gazebo supported officially through
1515
all the ROS packages. The different combinations of ROS <-> Gazebo can be
1616
found in the [REP-3](http://www.ros.org/reps/rep-2000.html). Some examples:
1717

18-
* ROS 2 Foxy: Citadel
1918
* ROS 2 Humble: Fortress
2019
* ROS 2 Iron: Fortress
2120

terminal-dashboard/_dashboard_lib.sh

+1-19
Original file line numberDiff line numberDiff line change
@@ -6,25 +6,7 @@ get_libraries_by_collection()
66
{
77
local COLLECTION=${1}
88

9-
if [ "$COLLECTION" = "citadel" ]; then
10-
LIBS="
11-
ignition-cmake2
12-
ignition-math6
13-
ignition-tools
14-
ignition-common3
15-
ignition-msgs5
16-
ignition-transport8
17-
ignition-fuel-tools4
18-
ignition-plugin
19-
ignition-rendering3
20-
sdformat9
21-
ignition-physics2
22-
ignition-sensors3
23-
ignition-gui3
24-
ignition-gazebo3
25-
ignition-launch2
26-
ignition-citadel"
27-
elif [ "$COLLECTION" = "fortress" ]; then
9+
if [ "$COLLECTION" = "fortress" ]; then
2810
LIBS="
2911
ignition-cmake2
3012
ignition-math6

terminal-dashboard/table.bash

+3-5
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ SCRIPT_DIR="${SCRIPT_DIR%/*}"
66

77
# Arguments
88
#
9-
# 1. <collection>: Required: A supported collection, i.e. "citadel", "fortesss", etc.
9+
# 1. <collection>: Required: A supported collection, i.e. "fortress", "harmonic", etc.
1010
# 2. <package_repo>: Optional: stable / prerelease / nightly (defaults to stable)
1111
#
1212
# Usage
@@ -32,7 +32,7 @@ ARCHS=( "amd64")
3232
DISTROS=( "ubuntu" )
3333
# No nightlies or pre-releases for arm
3434
if [[ $PACKAGE_REPO == "stable" ]]; then
35-
if [[ $COLLECTION == "citadel" || $COLLECTION == "fortress" ]]; then
35+
if [[ $COLLECTION == "fortress" ]]; then
3636
ARCHS+=( "i386" )
3737
fi
3838

@@ -61,9 +61,7 @@ for LIB in $(get_libraries_by_collection "${COLLECTION}" ); do
6161
for DISTRO in "${DISTROS[@]}"
6262
do
6363
if [[ $DISTRO == "ubuntu" ]]; then
64-
if [[ $COLLECTION == "citadel" ]]; then
65-
VERS=( "bionic" "focal" )
66-
elif [[ $COLLECTION == "fortress" ]]; then
64+
if [[ $COLLECTION == "fortress" ]]; then
6765
VERS=( "bionic" "focal" "jammy" )
6866
elif [[ $COLLECTION == "harmonic" ]]; then
6967
VERS=( "jammy" )

0 commit comments

Comments
 (0)