Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support output entire simulation box in text file and L1 error output of slice and box #415

Merged
merged 14 commits into from
Jan 25, 2025
Merged

Support output entire simulation box in text file and L1 error output of slice and box #415

merged 14 commits into from
Jan 25, 2025

Conversation

ChunYen-Chen
Copy link
Collaborator

This PR includes a commit (cb9f6415cd97da2ac9aa9dc5ba106eec7650abea) form @jzuhone.

Resolves

Resolves #409
Resolves #402

@ChunYen-Chen ChunYen-Chen added enhancement output Data output and log labels Jan 24, 2025
hyschive
hyschive requested changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@hyschive hyschive left a comment •
edited by ChunYen-Chen
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the description of OUTPUT_PART in the following test problem files as well:

  • ELBDM/RestrictionMismatch/Input__Parameter*
  • ELBDM/Perturbation/Input__Parameter_BaseSpectral
  • Hydro/AGORA_IsolatedGalaxy/Input_Options/Input__Parameter*

@ChunYen-Chen ChunYen-Chen requested a review from hyschive January 24, 2025 16:00
@ChunYen-Chen
Copy link
Collaborator Author

@hyschive Thanks for the review. I have updated the PR.

hyschive
hyschive reviewed Jan 25, 2025
View reviewed changes
Copy link
Contributor

@hyschive hyschive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final comments added.

@ChunYen-Chen ChunYen-Chen requested a review from hyschive January 25, 2025 15:31
@hyschive hyschive merged commit 5d779cd into gamer-project:main Jan 25, 2025
@ChunYen-Chen ChunYen-Chen deleted the output_box branch January 25, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyschive hyschive hyschive approved these changes

Assignees
No one assigned
Labels
enhancement output Data output and log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support outputting entire box for OPT__OUTPUT_PART Support slices and entire domain in Output_L1Error
3 participants
@ChunYen-Chen @hyschive @jzuhone