[Bugfix] SwitchFinerLevelsToWaveScheme in Refine.cpp #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hyschive Thank you for this bugfix and sorry for my late reply. That absolutely makes sense and I am sorry I had not thought of this before. |
KunkelAlexander
approved these changes
Feb 16, 2025
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bugfix prevents
SwitchFinerLevelsToWaveSchemefrom being reset tofalseinRefine.cppin the serial mode. This issue happens when a fluid patch at theELBDM_FIRST_WAVE_LEVEL-1level is flagged for refinement by criteria other thanOPT__FLAG_INTERFERENCE. Note that the parallel routineLB_Refine_GetNewRealPatchList.cppdoes not have this problem.