Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FDM (psiDM) #376

Merged
merged 1,570 commits into from
Dec 10, 2024
Merged

Support FDM (psiDM) #376

merged 1,570 commits into from
Dec 10, 2024

Conversation

hyschive
Copy link
Contributor

Support fuzzy dark matter simulations, also referred to as \psi dark matter (psiDM), wave dark matter, or extremely light bosonic dark matter (ELBDM).

Set --model=ELBDM for such simulations.

KunkelAlexander and others added 30 commits January 7, 2024 16:49
@hyschive hyschive added the fdm Fuzzy dark matter label Nov 25, 2024
Copy link
Collaborator

@ChunYen-Chen ChunYen-Chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hyschive The PR looks good to me. I have left some minor comments and one question.

I noticed that GlobalTree always be deleted before getting the current AMR structure. Is there a reason to implement GlobalTree as a struct instead of a class? I think the code can be much cleaner if it is a class.

TODOs in the follow-up PR:

  • Wiki of ELBDM
    • configure options
    • ELBDM scheme
    • Spectral refinement
    • New runtime parameters
      • SPEC_INT_VORTEX_THRESHOLD
      • SPEC_INT_GHOST_BOUNDARY
      • ...
  • Update all generate_make.sh according to Wiki update: gamer usage #332
  • Update Python scripts under example to be compatible with Python3 (and the latest yt)
  • Unify the code style of ELBDM code
  • Update the implementation of amr->use_wave_flag[] to improve the readability
  • Generalize the spectral refinement criterion to make it dimensionless(?)

@hyschive hyschive merged commit 430fe01 into gamer-project:main Dec 10, 2024
@technic960183 technic960183 mentioned this pull request Dec 12, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fdm Fuzzy dark matter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants