Skip to content

Commit 1a65811

Browse files
authored
compilation error gcc 8.5 with [-Werror=suggest-override]
1 parent 5ebfc92 commit 1a65811

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

include/spdlog/sinks/ansicolor_sink.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class ansicolor_sink : public sink {
4040

4141
void log(const details::log_msg &msg) override;
4242
void flush() override;
43-
void set_pattern(const std::string &pattern) final;
43+
void set_pattern(const std::string &pattern) final override;
4444
void set_formatter(std::unique_ptr<spdlog::formatter> sink_formatter) override;
4545

4646
// Formatting codes

include/spdlog/sinks/base_sink.h

+4-4
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ class SPDLOG_API base_sink : public sink {
2828
base_sink &operator=(const base_sink &) = delete;
2929
base_sink &operator=(base_sink &&) = delete;
3030

31-
void log(const details::log_msg &msg) final;
32-
void flush() final;
33-
void set_pattern(const std::string &pattern) final;
34-
void set_formatter(std::unique_ptr<spdlog::formatter> sink_formatter) final;
31+
void log(const details::log_msg &msg) final override;
32+
void flush() final override;
33+
void set_pattern(const std::string &pattern) final override;
34+
void set_formatter(std::unique_ptr<spdlog::formatter> sink_formatter) final override;
3535

3636
protected:
3737
// sink formatter

0 commit comments

Comments
 (0)