Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requestAPI handler to allow full server response to be processed #89

Open
RRosio opened this issue Feb 28, 2025 · 1 comment · May be fixed by #90
Open

Update requestAPI handler to allow full server response to be processed #89

RRosio opened this issue Feb 28, 2025 · 1 comment · May be fixed by #90
Labels
bug Something isn't working release-blocker

Comments

@RRosio
Copy link
Collaborator

RRosio commented Feb 28, 2025

While the server may send detailed information about error messages, for status codes >= 400, the following check prevents the frontend from accessing that server response (the payload shows up in the dev console but the response object is null).

if (!response.ok) {
throw new ServerConnection.ResponseError(response, data.message || data);
}

@RRosio RRosio added bug Something isn't working release-blocker labels Feb 28, 2025
@RRosio
Copy link
Collaborator Author

RRosio commented Feb 28, 2025

This is related to #86 and was found when debugging #88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release-blocker
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant