Support cookie-authenticated httpx client

[davidbrochart]

I am passing a cookie-authenticated httpx.AsyncClient to aconnect_ws, but it seems that the cookie is not taken into account because I get a 403.
Could it be that this is not implemented yet in http-ws?

[frankie567]

Normally, httpx-ws does nothing about it, it'll pass the headers and cookies "as if" and let HTTPX manage them. Could you try to catch WebSocketUpgradeError and log the request headers?

async with httpx.AsyncClient() as client:
    try:
        async with aconnect_ws("http://localhost:8000/ws", client) as ws:
            message = await ws.receive_text()
            print(message)
            await ws.send_text("Hello!")
    except WebSocketUpgradeError as e:
        print(e.response.request.headers)

[frankie567]

Ok, so cookie is correctly set in the request headers. Are you sure your WebSocket endpoint correctly decodes the token?

[davidbrochart]

I figured out the issue, it was just that the WebSocket router was not defined on my side 🤦‍♂️
What was misleading though is that I got a 403, maybe it should have been a 404?
Anyway, thanks a lot for your help, and sorry for the noise!

[frankie567]

Ha, great! Well, if you got a 403, I would say you had another router that would take precedence. Otherwise, in standard FastAPI context, you would definitely get a 404.

[davidbrochart]

Actually, not for WebSockets: fastapi/fastapi#572.

[frankie567]

Oh wow, I wasn't aware of that, thank you for the pointer! That's quite surprising 😲