Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROBE_ACCURACY not available for BTT Eddy #1604

Open
thijstriemstra opened this issue Feb 16, 2025 · 5 comments
Open

PROBE_ACCURACY not available for BTT Eddy #1604

thijstriemstra opened this issue Feb 16, 2025 · 5 comments
Labels
FR - Enhancement New feature or request

Comments

@thijstriemstra
Copy link
Contributor

Fluidd Version

1.32.2

Browser

Firefox

Device

Desktop PC

Operating System

Windows

What happened

The PROBE_ACCURACY command is not available when using BTT Eddy probe:

Image

What did you expect to happen

That the command is available for [probe_eddy_current] devices.

How to reproduce

Define an [probe_eddy_current btt_eddy]

Additional information

No response

@thijstriemstra thijstriemstra added GH - Bug Something isn't working GH - Evaluation Needed This topic needs to be discussed to evaluate it's aspects and feasability labels Feb 16, 2025
@pedrolamas pedrolamas added FR - Enhancement New feature or request and removed GH - Bug Something isn't working GH - Evaluation Needed This topic needs to be discussed to evaluate it's aspects and feasability labels Feb 16, 2025
@pedrolamas pedrolamas added this to the 1.32.3 milestone Feb 16, 2025
@pedrolamas pedrolamas self-assigned this Feb 16, 2025
@pedrolamas
Copy link
Member

Hi @thijstriemstra, thank you for opening this issue.

I've changed the status from "bug" to "feature request" as we never added support for probe_eddy_current objects, but we will add it in time for next release!

@pedrolamas
Copy link
Member

For what is worth, reading through the Klipper documentation tells me that PROBE_ACCURACY is not just for BTT Eddy but for any probe in the system, but we currently do not show that command in the interface (only the PROBE_CALIBRATE)

The main issue I see is if we start adding all of these we quickly can run out of space!

@thijstriemstra
Copy link
Contributor Author

thijstriemstra commented Feb 16, 2025

understood, but since fluidd is a frontend that makes things easier: i keep typing something into the fluidd console (and having to remember syntax) that should be as easy as a button click imo. it also helps people that are new and perhaps didn't even know the PROBE_ACCURACY command is available.

The main issue I see is if we start adding all of these we quickly can run out of space!

The main issue i see is my mind running out of space to store all these klipper commands and syntax ;-)

Maybe it's time for a diagnostics mode for probes where only these "advanced" options are visible..

@pedrolamas pedrolamas removed their assignment Feb 18, 2025
@pedrolamas
Copy link
Member

Maybe it's time for a diagnostics mode for probes where only these "advanced" options are visible..

I do like that idea! No promises, but I will be looking at this when I get the chance! 🙂

@thijstriemstra
Copy link
Contributor Author

i think it makes sense to move all probe-related tuning and calibration options into the "Tune" panel, just like bed mesh calibration being located there. z-tilt and other calibration tools could live there as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants