Add brushes for checked toggle buttons #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change the priority of the 'IsPressed' trigger so that it overrides the other brushes (looks better when clicking a checked button and is how Word 2013+2016 seem to work).
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added brushes for checked toggle buttons to the accent resources (including the 'Accent.Template.xaml' and ThemeHelper), and updated the control template to use them. I've copied the original brushes that were being used before, so they should still look the same.
I have however changed the priority of the 'IsPressed' trigger so that pressing a toggle button will always use the pressed brushes regardless of the 'IsChecked' property. This makes it clearer when a checked button is being pressed and fits with how Office 2013+2016 look, but I'm not sure which way looks better so I can undo this change if you'd prefer.